Skip to content

Bug 1886131: ci-operator/config/openshift/release: Drop 'abort-at=100' for e2e-44-stable-to-45-ci #12535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 12, 2020
Merged

Bug 1886131: ci-operator/config/openshift/release: Drop 'abort-at=100' for e2e-44-stable-to-45-ci #12535

openshift-merge-robot merged 1 commit into from
Nov 12, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Oct 8, 2020

The 4.4 -> 4.5 -> 4.4 flow was breaking on the etcd downgrade. Set the environment variable to clobber the workflow default:

$ git grep TEST_OPTIONS ci-operator/step-registry | grep workflow
ci-operator/step-registry/openshift/upgrade/aws/loki/openshift-upgrade-aws-loki-workflow.yaml:      TEST_OPTIONS: "abort-at=100"
ci-operator/step-registry/openshift/upgrade/gcp/loki/openshift-upgrade-gcp-loki-workflow.yaml:      TEST_OPTIONS: "abort-at=100"

and avoid the rollback.

@wking
ci-operator/config/openshift/release: Drop 'abort-at=100' for e2e-44-…
8630a4f 
…stable-to-45-ci

The 4.4 -> 4.5 -> 4.4 flow was breaking on the etcd downgrade [1].
Set the environment variable to clobber the workflow default:

  $ git grep TEST_OPTIONS ci-operator/step-registry | grep workflow
  ci-operator/step-registry/openshift/upgrade/aws/loki/openshift-upgrade-aws-loki-workflow.yaml:      TEST_OPTIONS: "abort-at=100"
  ci-operator/step-registry/openshift/upgrade/gcp/loki/openshift-upgrade-gcp-loki-workflow.yaml:      TEST_OPTIONS: "abort-at=100"

and avoid the rollback.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1886131
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2020

@wking: This pull request references Bugzilla bug 1886131, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1886131: ci-operator/config/openshift/release: Drop 'abort-at=100' for e2e-44-stable-to-45-ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 8, 2020
wking
wking commented Oct 8, 2020
View reviewed changes
ci-operator/config/openshift/release/openshift-release-master__ocp-4.5-ci.yaml
cluster_profile: aws
env:
TEST_OPTIONS: ""
workflow: openshift-upgrade-aws
Copy link
Member Author

@wking wking Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, only the Loki workflows default to TEST_OPTIONS setting abort-at. I'm still a bit fuzzy about why this one seems to be pulling it in.

Copy link
Contributor

@vrutkovs vrutkovs Oct 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that job is related - it appears to affect rollback jobs only

Nervermind, abort-at means "start rollback" not "cancel upgrade and stop". Seems it needs to be removed from the default options and be applied on rollback jobs only - #12544

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 9, 2020
Merged
@alvaroaleman
Copy link
Contributor

alvaroaleman commented Oct 30, 2020

/uncc

@openshift-ci-robot openshift-ci-robot removed the request for review from alvaroaleman October 30, 2020 20:34
@vrutkovs
Copy link
Contributor

vrutkovs commented Nov 11, 2020

/retest

vrutkovs
vrutkovs approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit a5b11f0 into openshift:master Nov 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2020

@wking: Bugzilla bug 1886131 is in an unrecognized state (CLOSED (CURRENTRELEASE)) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 1886131: ci-operator/config/openshift/release: Drop 'abort-at=100' for e2e-44-stable-to-45-ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2020

@wking: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-release-master__ocp-4.5-ci.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.5-ci.yaml
Details

In response to this:

The 4.4 -> 4.5 -> 4.4 flow was breaking on the etcd downgrade. Set the environment variable to clobber the workflow default:

$ git grep TEST_OPTIONS ci-operator/step-registry | grep workflow
ci-operator/step-registry/openshift/upgrade/aws/loki/openshift-upgrade-aws-loki-workflow.yaml:      TEST_OPTIONS: "abort-at=100"
ci-operator/step-registry/openshift/upgrade/gcp/loki/openshift-upgrade-gcp-loki-workflow.yaml:      TEST_OPTIONS: "abort-at=100"

and avoid the rollback.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the no-rollback-for-4.4-to-4.5 branch September 21, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wking @openshift-ci-robot @alvaroaleman @vrutkovs @petr-muller @openshift-merge-robot