Skip to content

[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: adjust tests to rebased 1.20-beta.2 oc command #25704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 24, 2020
Merged

[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: adjust tests to rebased 1.20-beta.2 oc command #25704

openshift-merge-robot merged 1 commit into from
Nov 24, 2020

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Nov 23, 2020

  • oc convert command dropped
  • oc edit: *_EDITOR envs dropped
  • --config option dropped

@ingvagabund ingvagabund mentioned this pull request Nov 23, 2020
Closed
@ingvagabund ingvagabund force-pushed the oc-4.7-kubernetes-1.20.0-beta.2 branch from b19ace6 to c953c5d Compare November 23, 2020 11:06
soltysh
soltysh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2020
@ingvagabund
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: a…
c1148c9 
…djust tests to rebased 1.20-beta.2 oc command

- oc convert command dropped
- oc edit: OC_EDITOR env dropped
- --config option dropped

Running `make update` after the changes
@ingvagabund ingvagabund force-pushed the oc-4.7-kubernetes-1.20.0-beta.2 branch from c953c5d to c1148c9 Compare November 23, 2020 11:34
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
soltysh
soltysh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Nov 23, 2020

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 23, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 23, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 23, 2020

/retest

2 similar comments
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 23, 2020

/retest

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 23, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 61ff579 into openshift:master Nov 24, 2020
@ingvagabund ingvagabund deleted the oc-4.7-kubernetes-1.20.0-beta.2 branch November 24, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ingvagabund @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot