Oc rebase to k8s 1.20.0-beta.2 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ingvagabund wants to merge 14 commits into openshift:master from ingvagabund:oc-4.7-kubernetes-1.20.0-beta.2

Member

ingvagabund commented Nov 20, 2020 •

edited

Loading

Following steps in https://github.com/openshift/enhancements/blob/master/enhancements/oc/upgrade_kubernetes.md


          Pin to 1.20.0-beta.2

18221ed

openshift-ci-robot added the do-not-merge/work-in-progress label

openshift-ci-robot requested review from mfojtik and soltysh

November 20, 2020 20:23

ingvagabund force-pushed the oc-4.7-kubernetes-1.20.0-beta.2 branch 2 times, most recently from c7bf0bc to e2bdc53 Compare

November 20, 2020 22:09

ingvagabund changed the title ~~WIP: Oc 4.7 kubernetes 1.20.0 beta.2~~ Oc 4.7 kubernetes 1.20.0 beta.2

openshift-ci-robot removed the do-not-merge/work-in-progress label

ingvagabund changed the title ~~Oc 4.7 kubernetes 1.20.0 beta.2~~ Oc rebase to k8s 1.20.0-beta.2

Member Author

ingvagabund commented Nov 21, 2020

/retest

1 similar comment

Member Author

ingvagabund commented Nov 22, 2020

/retest

Member Author

ingvagabund commented Nov 23, 2020

openshift/origin#25704 to address failing tests in e2e-agnostic-cmd.

soltysh mentioned this pull request

[WIP] Test bump 1.20 #636

Closed

ingvagabund mentioned this pull request

OCP 4.7 Release Notes Tracker openshift/openshift-docs#26801

Closed

soltysh suggested changes

View reviewed changes

Contributor

soltysh left a comment

As a follow-up have a look at how much of oc debug can we squash into kubectl debug

pkg/helpers/kubeconfig/loader.go

-              	return NewPathOptionsWithConfig(kcmdutil.GetFlagString(cmd, genericclioptions.OpenShiftKubeConfigFlagName))
-              }
-              func NewPathOptionsWithConfig(configPath string) *kclientcmd.PathOptions {

Contributor

soltysh Nov 23, 2020

I'm inclined to drop this file entirely. The only difference between this and kclientcmd.NewDefaultPathOptions is LoadingRules.DoNotResolvePaths but I'd try it, it shouldn't affect us.

Contributor

soltysh Nov 23, 2020

From what I see we use it in login, logout, project, request project and projects commands.

soltysh mentioned this pull request

update discovery burst to reflect lots of CRDs on openshift clusters #645

Closed

ingvagabund and others added 12 commits

November 24, 2020 13:37


          Pin openshift deps to 1.20.0-beta.2 branches

76c0fed


          Drop legacyscheme and convert command

c1797ad


          Update k8s.io imports

72d2e75


          Drop dependency on removed genericclioptions.OpenShiftKubeConfigFlagName

47f2412


          pkg/helpers/describe UserOAuthAccessToken ignore missing describer

8e2696e


          Replace RoleBindingBuilder with direct RoleBinding construction

f270200


          Copy credentialprovider from kubernetes

191b7db


          Drop verify-imports

ad1af1c


          Set default discovery burst to 200

da2ace5


          go mod tidy && go mod vendor

5a83dfe


          Bump k8s version in Makefile

cbf5c4d


          Run ./hack/update-generated-completions.sh

57f4de0

ingvagabund force-pushed the oc-4.7-kubernetes-1.20.0-beta.2 branch from e2bdc53 to 57f4de0 Compare

November 24, 2020 12:41


          Drop pkg/helpers/kubeconfig.NewPathOptions

4a9abff

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

21 similar comments

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-merge-robot commented Dec 2, 2020

@ingvagabund: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-serial	`4a9abff`	link	`/test e2e-aws-serial`
ci/prow/e2e-aws	`4a9abff`	link	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Member Author

ingvagabund commented Dec 2, 2020

/hold

openshift-ci-robot added the do-not-merge/hold label

Contributor

soltysh commented Dec 2, 2020

/close
in favor of #660

openshift-ci-robot commented Dec 2, 2020

@soltysh: Closed this PR.

Details

In response to this:

/close
in favor of #660

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot closed this

ingvagabund deleted the oc-4.7-kubernetes-1.20.0-beta.2 branch

December 2, 2020 18:34

soltysh mentioned this pull request

[release-4.6] Bug 1906332: bump discovery burst to 250 #716

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/hold lgtm