Skip to content

Oc 4.7 kubernetes 1.20.0 beta.2 #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 14 commits into from
Dec 4, 2020
Merged

Oc 4.7 kubernetes 1.20.0 beta.2 #660

openshift-merge-robot merged 14 commits into from
Dec 4, 2020

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Dec 1, 2020 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 1, 2020

/test e2e-aws

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 1, 2020

/retest

2 similar comments
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 1, 2020

/retest

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 1, 2020

/retest

@ingvagabund ingvagabund force-pushed the oc-4.7-kubernetes-1.20.0-beta.2-keep-oc-login-untouched branch from 39f1bf6 to 441ef05 Compare December 2, 2020 11:20
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 2, 2020

e2e-aws-serial will not go green until openshift/origin#25715 is merged

@ingvagabund ingvagabund changed the title Oc 4.7 kubernetes 1.20.0 beta.2 keep oc login untouched Oc 4.7 kubernetes 1.20.0 beta.2 Dec 2, 2020
soltysh
soltysh approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh soltysh mentioned this pull request Dec 2, 2020
Closed
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor

soltysh commented Dec 3, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor

soltysh commented Dec 3, 2020

/hold
for origin PR to land first

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 4, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 4, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 4, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit db6b7f1 into openshift:master Dec 4, 2020
@ingvagabund ingvagabund deleted the oc-4.7-kubernetes-1.20.0-beta.2-keep-oc-login-untouched branch December 4, 2020 15:56
@guillaumerose guillaumerose mentioned this pull request Dec 6, 2020
Merged
@ingvagabund ingvagabund mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ingvagabund @openshift-ci-robot @openshift-bot @soltysh @openshift-merge-robot