Skip to content

[sig-auth][Feature:LDAP][Serial] ldap group sync can sync groups from ldap: do not oc cp nonexisting folders #25715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 4, 2020
Merged

[sig-auth][Feature:LDAP][Serial] ldap group sync can sync groups from ldap: do not oc cp nonexisting folders #25715

openshift-merge-robot merged 1 commit into from
Dec 4, 2020

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Nov 29, 2020 •
edited
Loading

When trying to upload an unexisting file to a pod, kubectl currently doesn't print any error message and terminates with a zero exit code.

kubernetes/kubernetes#90333

With openshift/oc#648 where the new check is coming in, the test starts to fail since test/extended/authentication/ldap does not exist.

Skipping the test for now. Opening https://bugzilla.redhat.com/show_bug.cgi?id=1902702 to address the broken parts.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 29, 2020
@ingvagabund ingvagabund changed the title WIP: DEBUG: [sig-auth][Feature:LDAP][Serial] ldap group sync can sync… [sig-auth][Feature:LDAP][Serial] ldap group sync can sync groups from ldap: do not oc cp nonexisting folders Nov 30, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 30, 2020

Passing locally

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
soltysh
soltysh approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2020
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 30, 2020

/test e2e-aws-fips

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 30, 2020

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 30, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 30, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 1, 2020

/retest

2 similar comments
@stlaz
Copy link
Contributor

stlaz commented Dec 1, 2020

/retest

@soltysh
Copy link
Contributor

soltysh commented Dec 1, 2020

/retest

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 1, 2020

[sig-auth][Feature:LDAP][Serial] ldap group sync can sync groups from ldap [Skipped:broken] [Suite:openshift/conformance/serial] is not skipped

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@stlaz
Copy link
Contributor

stlaz commented Dec 1, 2020

/lgtm

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 2, 2020

/retest

@ingvagabund ingvagabund mentioned this pull request Dec 2, 2020
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 2, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 2, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 3, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 3, 2020

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 3, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 68279d8 into openshift:master Dec 4, 2020
@ingvagabund ingvagabund deleted the tests-wip-debug branch December 4, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@knobunc knobunc Awaiting requested review from knobunc

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@stlaz stlaz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ingvagabund @openshift-bot @stlaz @soltysh @openshift-ci-robot @openshift-merge-robot