Bug 1948629: upgrades: add "none" / "minimal" test suites to skip disruption tests#26061
Conversation
vrutkovs
force-pushed
the
sno-upgrade-no-disruption
branch
from
19e5b9a to
c5af5af
Compare
| upgrade.SetToImage(opt.ToImage) | ||
| switch opt.Suite { | ||
| case "none": | ||
| return filterUpgrade(upgrade.MinimalTests(), func(string) bool { return true }) |
There was a problem hiding this comment.
Wait... none would be no tests. None should be "zero things get run". You still need to skip some tests for single mode (in the test, not here).
There was a problem hiding this comment.
Ah, sure. Lets start with none (mostly for paused workers) / minimal (SNO) suites
There was a problem hiding this comment.
I would prefer you don't add minimal though - that's what I'm specifically asking you not to do :) To fix the tests.
As far as filtering, it was intended that you could filter test names with --dry-run and grep and then -f -, but it looks like that is broken for the upgrade subset tests.
There was a problem hiding this comment.
I would prefer to not run the invariants for upgrade for now, so none is probably sufficient for SNO
There was a problem hiding this comment.
Remove minimal, keeping none
vrutkovs
force-pushed
the
sno-upgrade-no-disruption
branch
from
c5af5af to
9b8d357
Compare
vrutkovs
changed the title
vrutkovs
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@vrutkovs: This pull request references Bugzilla bug 1948629, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
"none" suite is an empty set of tests. These would be handy in the following usecases: a) paused worker tests could skip disruption tests until final version is reached b) SNO upgrade tests are providing HA for the components, so distruption tests would permafail
vrutkovs
force-pushed
the
sno-upgrade-no-disruption
branch
from
9b8d357 to
1f22047
Compare
|
/retest |
|
/lgtm I will try to fix the "filter tests by name" |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@vrutkovs: All pull requests linked via external trackers have merged: Bugzilla bug 1948629 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
For SNO upgrades most disruption tests would fail as there is no HA. This option would allow SNO upgrade test suite to skip those