Add SNO upgrade workflows#17519
Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom Apr 19, 2021
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
vrutkovs
force-pushed
the
bip-upgrade
branch
2 times, most recently
from
00a9e85 to
e08062d
Compare
Contributor
Author
|
Reference: https://issues.redhat.com/browse/OTA-379 |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
vrutkovs
force-pushed
the
bip-upgrade
branch
4 times, most recently
from
a02a353 to
65334bd
Compare
wking
reviewed
Apr 8, 2021
wking
reviewed
Apr 8, 2021
vrutkovs
force-pushed
the
bip-upgrade
branch
13 times, most recently
from
18374fe to
3b75f9e
Compare
vrutkovs
force-pushed
the
bip-upgrade
branch
2 times, most recently
from
d8c53d8 to
bdf5630
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold I'll create a new PR to fix |
openshift-ci-robot
added
the
do-not-merge/hold
romfreiman
reviewed
Apr 18, 2021
There was a problem hiding this comment.
we called in single-node everywhere (rather than sno)
romfreiman
reviewed
Apr 18, 2021
romfreiman
reviewed
Apr 18, 2021
There was a problem hiding this comment.
is loki is something specific here? Just so i understand, or this is the standard flow
Contributor
There was a problem hiding this comment.
Copied from regular upgrade workflow
Contributor
Author
There was a problem hiding this comment.
This step would setup promtail on the cluster, sending container and journald logs to the central repo, which can be queried by Grafana.
This is a standard practice for upgrade workflows, as intermediate containers can be lost during reboot (or the node may never come back)
|
Lets add those jobs here as well: https://testgrid.k8s.io/redhat-single-node |
This setups SNO cluster on AWS from `release:initial` and upgrades it to `release:latest`. Disruption tests are skipped, as they are not expected to pass in SNO configuration. As a test this adds periodic job to be testing 4.8 CI images every 24 hours
This test suite won't run disruption tests
wking
reviewed
Apr 19, 2021
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| SINGLE_NODE_AZURE_INSTANCE_TYPE="Standard_D32s_v3" |
Member
There was a problem hiding this comment.
I expect there to be one set of folks maintaining these single-node conf step(s), so it might we worth a single single-node/conf command instead of the platform-specific sub-steps. On the other hand, I'm not in the maintainer set, so doesn't matter for me ;).
wking
approved these changes
Apr 19, 2021
Member
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
Looks pretty good to me. Remaining wrinkles can be ironed out in follow-up work.
/lgtm
/retest
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, omertuc, vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/hold cancel All issues were resolved |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
@vrutkovs: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setups SNO cluster on AWS and Azure from
release:initialand upgrades itto
release:latest. Disruption tests are skipped, as they are notexpected to pass in SNO configuration.
Split out from #16290 to speed up review.
TODO:
storageoperator on AWS - https://bugzilla.redhat.com/show_bug.cgi?id=1947402