Skip to content

Conversation

@hexfusion
Copy link
Contributor

Signed-off-by: Sam Batschelet sbatsche@redhat.com

cc @bparees

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci openshift-ci bot requested review from knobunc and mfojtik June 18, 2021 13:59
@bparees
Copy link
Contributor

bparees commented Jun 18, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2021
@lilic
Copy link
Contributor

lilic commented Jun 18, 2021

🎉 /lgtm :)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1012b2c into openshift:master Jun 18, 2021
wking added a commit to wking/origin that referenced this pull request Jun 29, 2021
…/{org}/{repo}

Experiment to see if we can get autoowners [1] working here, so
component teams don't need manual bumps like 050920c
(test/extended: add etcd OWNERS, 2021-06-18, openshift#26249).

[1]: https://github.com/openshift/ci-tools/blob/64bde4a5f06d600725ddcc59f8d88410ec4fbe35/cmd/autoowners/README.md
wking added a commit to wking/origin that referenced this pull request Jun 29, 2021
…/{org}/{repo}

Experiment to see if we can get autoowners [1] working here, so
component teams don't need manual bumps like 050920c
(test/extended: add etcd OWNERS, 2021-06-18, openshift#26249).

[1]: https://github.com/openshift/ci-tools/blob/64bde4a5f06d600725ddcc59f8d88410ec4fbe35/cmd/autoowners/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants