-
Notifications
You must be signed in to change notification settings - Fork 4.8k
test/extended/openshift/cluster-etcd-operator: Shift to test/extended/{org}/{repo} #26287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…/{org}/{repo}
Experiment to see if we can get autoowners [1] working here, so
component teams don't need manual bumps like 050920c
(test/extended: add etcd OWNERS, 2021-06-18, openshift#26249).
[1]: https://github.com/openshift/ci-tools/blob/64bde4a5f06d600725ddcc59f8d88410ec4fbe35/cmd/autoowners/README.md
|
Something like: $ podman run -v "${PWD}:/tmp/work:z" --workdir /tmp/work -it --rm registry.ci.openshift.org/ci/autoowners -- -target-subdir test -config-subdirs extendedshould be able to show if this works before we merge this PR... |
|
Tested with ci-tools and origin checked out to sibling repositories: $ go run ./cmd/autoowners -debug-mode -dry-run -target-dir ../origin -target-subdir test -config-subdir extended
...
WARN[0000] empty -github-token-path, will use anonymous github client
...
INFO[0000] ListOrgMembers(openshift, all) client=github
INFO[0002] handling repo ... orgRepo=util/image
INFO[0002] GetFile(util, image, OWNERS, ) client=github
DEBU[0002] GetFile(util, image, OWNERS, ) finished client=github duration=574.249751ms
DEBU[0002] Not found file in the upstream repo filename=OWNERS orgRepo=util/image
INFO[0002] GetFile(util, image, OWNERS_ALIASES, ) client=github
DEBU[0003] GetFile(util, image, OWNERS_ALIASES, ) finished client=github duration=479.108876ms
DEBU[0003] Not found file in the upstream repo filename=OWNERS_ALIASES orgRepo=util/image
WARN[0003] Ignoring the repo with no OWNERS file in the upstream repo. orgRepo=util/image
...
FATA[0045] Error occurred when walking through the target dir. error="[sleep time for token reset exceeds max sleep time (59m29.131350746s > 2m0s), sleep time for token reset exceeds max sleep time (59m28.188244704s > 2m0s), sleep time for token reset exceeds max sleep time (59m26.518544453s > 2m0s), sleep time for token reset exceeds max sleep time (59m26.855662828s > 2m0s), sleep time for token reset exceeds max sleep time (59m26.263843703s > 2m0s), sleep time for token reset exceeds max sleep time (59m25.916787161s > 2m0s), sleep time for token reset exceeds max sleep time (59m24.528064911s > 2m0s), sleep time for token reset exceeds max sleep time (59m25.017806035s > 2m0s), sleep time for token reset exceeds max sleep time (59m23.587886452s > 2m0s), sleep time for token reset exceeds max sleep time (59m24.099038452s > 2m0s), sleep time for token reset exceeds max sleep time (59m22.686763243s > 2m0s), sleep time for token reset exceeds max sleep time (59m23.178590035s > 2m0s), sleep time for token reset exceeds max sleep time (59m21.760023826s > 2m0s), sleep time for token reset exceeds max sleep time (59m22.197765409s > 2m0s), sleep time for token reset exceeds max sleep time (59m20.735752576s > 2m0s), sleep time for token reset exceeds max sleep time (59m21.229358284s > 2m0s), sleep time for token reset exceeds max sleep time (59m19.820729742s > 2m0s), sleep time for token reset exceeds max sleep time (59m19.413641533s > 2m0s), sleep time for token reset exceeds max sleep time (59m18.981510533s > 2m0s), sleep time for token reset exceeds max sleep time (59m17.639510657s > 2m0s), sleep time for token reset exceeds max sleep time (59m18.165772824s > 2m0s), sleep time for token reset exceeds max sleep time (59m16.753134407s > 2m0s), sleep time for token reset exceeds max sleep time (59m17.344998782s > 2m0s)]"
exit status 1Not sure what that error's about. And we may want even more namespacing so we don't bother hitting GitHub for things that aren't actually repositories. $ git --no-pager diff
diff --git a/test/extended/openshift/cluster-etcd-operator/OWNERS b/test/extended/openshift/cluster-etcd-operator/OWNERS
index 483fe58429..7a0c4a9be9 100644
--- a/test/extended/openshift/cluster-etcd-operator/OWNERS
+++ b/test/extended/openshift/cluster-etcd-operator/OWNERS
@@ -1,10 +1,11 @@
-reviewers:
- - hexfusion
- - lilic
- - marun
- - smarterclayton
+# DO NOT EDIT; this file is auto-generated using https://github.com/openshift/ci-tools.
+# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
+
approvers:
- - hexfusion
- - lilic
- - marun
- - smarterclayton
+- hexfusion
+options: {}
+reviewers:
+- hexfusion
+- ironcladlou
+- lilic
+- marunso seems to work :). |
|
|
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Experiment to see if we can get
autoownersworking here, so component teams don't need manual bumps like 050920c (#26249).