Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jun 29, 2021

Experiment to see if we can get autoowners working here, so component teams don't need manual bumps like 050920c (#26249).

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign ashcrow after the PR has been reviewed.
You can assign the PR to them by writing /assign @ashcrow in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…/{org}/{repo}

Experiment to see if we can get autoowners [1] working here, so
component teams don't need manual bumps like 050920c
(test/extended: add etcd OWNERS, 2021-06-18, openshift#26249).

[1]: https://github.com/openshift/ci-tools/blob/64bde4a5f06d600725ddcc59f8d88410ec4fbe35/cmd/autoowners/README.md
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2021
@wking
Copy link
Member Author

wking commented Jun 29, 2021

Something like:

$ podman run -v "${PWD}:/tmp/work:z" --workdir /tmp/work -it --rm registry.ci.openshift.org/ci/autoowners -- -target-subdir test -config-subdirs extended

should be able to show if this works before we merge this PR...

@wking
Copy link
Member Author

wking commented Jun 29, 2021

Tested with ci-tools and origin checked out to sibling repositories:

$ go run ./cmd/autoowners -debug-mode -dry-run -target-dir ../origin -target-subdir test -config-subdir extended
...
WARN[0000] empty -github-token-path, will use anonymous github client 
...
INFO[0000] ListOrgMembers(openshift, all)                client=github
INFO[0002] handling repo ...                             orgRepo=util/image
INFO[0002] GetFile(util, image, OWNERS, )                client=github
DEBU[0002] GetFile(util, image, OWNERS, ) finished       client=github duration=574.249751ms
DEBU[0002] Not found file in the upstream repo           filename=OWNERS orgRepo=util/image
INFO[0002] GetFile(util, image, OWNERS_ALIASES, )        client=github
DEBU[0003] GetFile(util, image, OWNERS_ALIASES, ) finished  client=github duration=479.108876ms
DEBU[0003] Not found file in the upstream repo           filename=OWNERS_ALIASES orgRepo=util/image
WARN[0003] Ignoring the repo with no OWNERS file in the upstream repo.  orgRepo=util/image
...
FATA[0045] Error occurred when walking through the target dir.  error="[sleep time for token reset exceeds max sleep time (59m29.131350746s > 2m0s), sleep time for token reset exceeds max sleep time (59m28.188244704s > 2m0s), sleep time for token reset exceeds max sleep time (59m26.518544453s > 2m0s), sleep time for token reset exceeds max sleep time (59m26.855662828s > 2m0s), sleep time for token reset exceeds max sleep time (59m26.263843703s > 2m0s), sleep time for token reset exceeds max sleep time (59m25.916787161s > 2m0s), sleep time for token reset exceeds max sleep time (59m24.528064911s > 2m0s), sleep time for token reset exceeds max sleep time (59m25.017806035s > 2m0s), sleep time for token reset exceeds max sleep time (59m23.587886452s > 2m0s), sleep time for token reset exceeds max sleep time (59m24.099038452s > 2m0s), sleep time for token reset exceeds max sleep time (59m22.686763243s > 2m0s), sleep time for token reset exceeds max sleep time (59m23.178590035s > 2m0s), sleep time for token reset exceeds max sleep time (59m21.760023826s > 2m0s), sleep time for token reset exceeds max sleep time (59m22.197765409s > 2m0s), sleep time for token reset exceeds max sleep time (59m20.735752576s > 2m0s), sleep time for token reset exceeds max sleep time (59m21.229358284s > 2m0s), sleep time for token reset exceeds max sleep time (59m19.820729742s > 2m0s), sleep time for token reset exceeds max sleep time (59m19.413641533s > 2m0s), sleep time for token reset exceeds max sleep time (59m18.981510533s > 2m0s), sleep time for token reset exceeds max sleep time (59m17.639510657s > 2m0s), sleep time for token reset exceeds max sleep time (59m18.165772824s > 2m0s), sleep time for token reset exceeds max sleep time (59m16.753134407s > 2m0s), sleep time for token reset exceeds max sleep time (59m17.344998782s > 2m0s)]"
exit status 1

Not sure what that error's about. And we may want even more namespacing so we don't bother hitting GitHub for things that aren't actually repositories.
But then in my origin checkout:

$ git --no-pager diff
diff --git a/test/extended/openshift/cluster-etcd-operator/OWNERS b/test/extended/openshift/cluster-etcd-operator/OWNERS
index 483fe58429..7a0c4a9be9 100644
--- a/test/extended/openshift/cluster-etcd-operator/OWNERS
+++ b/test/extended/openshift/cluster-etcd-operator/OWNERS
@@ -1,10 +1,11 @@
-reviewers:
-  - hexfusion
-  - lilic
-  - marun
-  - smarterclayton
+# DO NOT EDIT; this file is auto-generated using https://github.com/openshift/ci-tools.
+# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
+
 approvers:
-  - hexfusion
-  - lilic
-  - marun
-  - smarterclayton
+- hexfusion
+options: {}
+reviewers:
+- hexfusion
+- ironcladlou
+- lilic
+- marun

so seems to work :).

@wking
Copy link
Member Author

wking commented Jun 29, 2021

sleep time for token reset exceeds max sleep time is from here. Altering doRequest there to return whether or not an auth token was set, so we can make "GitHub is asking you to slow-down a lot" non-fatal in the no-token-supplied case seems like overkill, since when we run this in production we will certainly use a GitHub token. And I've opened openshift/ci-tools#2129 to reduce the number of GitHub requests being made as well. So I think we are good to go here, unless we wanted further namespacing (test/extended/repo/openshift/cluster-etcd-operator?) to make it easier to avoid pinging GitHub for directories which are not tied to repos.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2021

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify b1b337d link /test verify
ci/prow/e2e-aws-csi b1b337d link /test e2e-aws-csi
ci/prow/e2e-aws-fips b1b337d link /test e2e-aws-fips
ci/prow/e2e-aws-serial b1b337d link /test e2e-aws-serial
ci/prow/e2e-gcp-upgrade b1b337d link /test e2e-gcp-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 b1b337d link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2021

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2021
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 8, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants