Skip to content

Bug 1942164: Fix time calc ordering for upgrades #26324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 14, 2021
Merged

Bug 1942164: Fix time calc ordering for upgrades #26324

openshift-merge-robot merged 1 commit into from
Jul 14, 2021

Conversation

@jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Jul 13, 2021

The original PR #26202 use
parens in the wrong place and the actual time calcs were happening
wrong and garbage values were being used, like this job [0] where
the test output looked like:
: [sig-cluster-lifecycle] cluster upgrade should complete in -1386946h6m26.707003392s minutes

This should fix that.

[0] https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-gcp-ovn-upgrade/1414923427529101312

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

@jluhrsen
Bug 1942164: Fix time calc ordering for upgrades
5c56275 
The original PR openshift#26202 use
parens in the wrong place and the actual time calcs were happening
wrong and garbage values were being used, like this job [0] where
the test output looked like:
  : [sig-cluster-lifecycle] cluster upgrade should complete in -1386946h6m26.707003392s minutes

This should fix that.

[0] https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.9-upgrade-from-stable-4.8-e2e-gcp-ovn-upgrade/1414923427529101312

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

@jluhrsen: This pull request references Bugzilla bug 1942164, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1942164: Fix time calc ordering for upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bparees and csrwng July 13, 2021 21:48
@jluhrsen jluhrsen mentioned this pull request Jul 13, 2021
Merged
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jul 13, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

@jluhrsen: This pull request references Bugzilla bug 1942164, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wangke19 July 13, 2021 21:50
wking
wking approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@bparees
Copy link
Contributor

bparees commented Jul 13, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jluhrsen, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@stbenjam
Copy link
Member

stbenjam commented Jul 14, 2021

/retest

1 similar comment
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jul 14, 2021

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4f99a10 into openshift:master Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@jluhrsen: All pull requests linked via external trackers have merged:

Bugzilla bug 1942164 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1942164: Fix time calc ordering for upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/origin that referenced this pull request Jul 14, 2021
@wking
test/e2e/upgrade/upgrade: Unify duration-overshoot test-case name
bbb3a70 
5c56275 (Bug 1942164: Fix time calc ordering for upgrades,
2021-07-13, openshift#26324) adjusted how the failure-mode test-case name was
formed, but did not adjust the success-mode test-case name.  This
commit restructures to make it impossible to diverge going forward.
@wking wking mentioned this pull request Jul 14, 2021
Merged
wking added a commit to wking/origin that referenced this pull request Nov 30, 2021
@wking
test/e2e/upgrade/upgrade: Unify duration-overshoot test-case name
e7456a8 
5c56275 (Bug 1942164: Fix time calc ordering for upgrades,
2021-07-13, openshift#26324) adjusted how the failure-mode test-case name was
formed, but did not adjust the success-mode test-case name.  This
commit restructures to make it impossible to diverge going forward.
@wking wking mentioned this pull request Nov 30, 2021
Merged
DavidHurta pushed a commit to DavidHurta/origin that referenced this pull request Mar 2, 2022
@wking @DavidHurta
test/e2e/upgrade/upgrade: Unify duration-overshoot test-case name
be2b25d 
5c56275 (Bug 1942164: Fix time calc ordering for upgrades,
2021-07-13, openshift#26324) adjusted how the failure-mode test-case name was
formed, but did not adjust the success-mode test-case name.  This
commit restructures to make it impossible to diverge going forward.
@DavidHurta DavidHurta mentioned this pull request Mar 3, 2022
Closed
DavidHurta pushed a commit to DavidHurta/origin that referenced this pull request Mar 3, 2022
@wking @DavidHurta
test/e2e/upgrade/upgrade: Unify duration-overshoot test-case name
6ea3f7c 
5c56275 (Bug 1942164: Fix time calc ordering for upgrades,
2021-07-13, openshift#26324) adjusted how the failure-mode test-case name was
formed, but did not adjust the success-mode test-case name.  This
commit restructures to make it impossible to diverge going forward.
DavidHurta pushed a commit to DavidHurta/origin that referenced this pull request Mar 4, 2022
@wking @DavidHurta
test/e2e/upgrade/upgrade: Unify duration-overshoot test-case name
5502ec3 
5c56275 (Bug 1942164: Fix time calc ordering for upgrades,
2021-07-13, openshift#26324) adjusted how the failure-mode test-case name was
formed, but did not adjust the success-mode test-case name.  This
commit restructures to make it impossible to diverge going forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

@wangke19 wangke19 Awaiting requested review from wangke19

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jluhrsen @bparees @stbenjam @openshift-bot @wking @openshift-merge-robot