Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jul 14, 2021

5c56275 (#26324) adjusted how the failure-mode test-case name was formed, but did not adjust the success-mode test-case name. This commit restructures to make it impossible to diverge going forward.

5c56275 (Bug 1942164: Fix time calc ordering for upgrades,
2021-07-13, openshift#26324) adjusted how the failure-mode test-case name was
formed, but did not adjust the success-mode test-case name.  This
commit restructures to make it impossible to diverge going forward.
@openshift-ci openshift-ci bot requested review from smarterclayton and soltysh July 14, 2021 23:53
@wking
Copy link
Member Author

wking commented Jul 15, 2021

/assign @bparees

@bparees
Copy link
Contributor

bparees commented Jul 15, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1afbb85 into openshift:master Jul 15, 2021
@wking wking deleted the additional-update-duration-string-fix branch July 17, 2021 03:36
@wking
Copy link
Member Author

wking commented Jul 17, 2021

Success:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants