Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None #26998

honza · 2022-04-08T16:14:58Z

When cluster version capabilities is set to None, the baremetal platform
is disabled, and as such, the metal3 CRDs aren't present. Here, we load
the cluster version CR, and only include the metal3 CRDs when the
capabilities is set to anything other than None.

The error in CI is:

: [sig-cli] oc explain should contain proper spec+status for CRDs [Suite:openshift/conformance/parallel]

fail [github.com/openshift/origin/test/extended/cli/explain.go:494]: Unexpected error:
    <*errors.errorString | 0xc001f173c0>: {
        s: "exit status 1: the server doesn't have a resource type \"baremetalhosts\"",
    }
    exit status 1: the server doesn't have a resource type "baremetalhosts"
occurred

test/extended/cli/explain.go

bparees · 2022-04-29T14:46:41Z

/approve

this is a valid change/thing we need to do. but @wking's comments should be addressed prior to lgtm

When cluster version capabilities is set to None, the baremetal platform is disabled, and as such, the metal3 CRDs aren't present. Here, we load the cluster version CR, and only include the metal3 CRDs when the capabilities is set to anything other than None.

openshift-ci · 2022-05-25T16:33:43Z

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node-upgrade	`6d1143a`	link	false	`/test e2e-aws-single-node-upgrade`
ci/prow/e2e-aws-single-node	`6d1143a`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-agnostic-cmd	`6d1143a`	link	false	`/test e2e-agnostic-cmd`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

honza · 2022-05-26T12:43:38Z

/retest-required

openshift-ci · 2022-05-27T14:34:18Z

@honza: This pull request references Bugzilla bug 2091086, which is invalid:

expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

honza · 2022-05-27T14:35:06Z

/bugzilla refresh

openshift-ci · 2022-05-27T14:35:14Z

@honza: This pull request references Bugzilla bug 2091086, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking

/lgtm

openshift-ci · 2022-05-27T16:21:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, honza, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-05-27T19:29:36Z

@honza: All pull requests linked via external trackers have merged:

openshift/origin#26998

Bugzilla bug 2091086 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

… is enabled Like 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix: rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (chore(modules): bump openshift/api for new operatorhub crd, 2022-05-02, operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the 'marketplace' cluster-version capability.

… capability Clusters that disable the 'Console' capability are currently failing this test-case [1]: : [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel] expand_less Run #0: Failed expand_less 3s { fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Jan 3 13:43:14.134: test data for system:authenticated has too many unnecessary permissions: {APIGroups:["console.openshift.io"], Resources:["consoleclidownloads"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleexternalloglinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolelinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolenotifications"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleplugins"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolequickstarts"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleyamlsamples"], Verbs:["get" "list" "watch"]} {APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["get" "list"]} {APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]} Ginkgo exit error 1: exit with code 1} This commit uses the pattern that 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998) began using for CRDs to only add the console-linked rules when Console is enabled. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.13-e2e-aws-sdn-no-capabilities/1610257913278894080

… capability Clusters that disable the 'Console' capability are currently failing this test-case [1]: : [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel] expand_less Run #0: Failed expand_less 3s { fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Jan 3 13:43:14.134: test data for system:authenticated has too many unnecessary permissions: {APIGroups:["console.openshift.io"], Resources:["consoleclidownloads"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleexternalloglinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolelinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolenotifications"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleplugins"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolequickstarts"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleyamlsamples"], Verbs:["get" "list" "watch"]} {APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["get" "list"]} {APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]} Ginkgo exit error 1: exit with code 1} This commit uses the pattern that 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998) began using for CRDs to only add the console-linked rules when Console is enabled. It has also been around three years since bb09b26 (Add system:authenticated exception for CRDs used by console for extensions, 2019-06-21, openshift#23231)'s "eliminating this exception in the near future", so I'm softening that to "may eventually". Extending system:authenticated is still not a great pattern to follow, but it may never be worth the time it would take the console team to build an alternative mechanism. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.13-e2e-aws-sdn-no-capabilities/1610257913278894080

… capability Clusters that disable the 'Console' capability are currently failing this test-case [1]: : [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel] expand_less Run #0: Failed expand_less 3s { fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Jan 3 13:43:14.134: test data for system:authenticated has too many unnecessary permissions: {APIGroups:["console.openshift.io"], Resources:["consoleclidownloads"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleexternalloglinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolelinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolenotifications"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleplugins"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolequickstarts"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleyamlsamples"], Verbs:["get" "list" "watch"]} {APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["get" "list"]} {APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]} Ginkgo exit error 1: exit with code 1} This commit uses the pattern that 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998) began using for CRDs to only add the console-linked rules when Console is enabled, and to only add the snapshot-linked rules when `CSISnapshot` is enabled. It has also been around three years since bb09b26 (Add system:authenticated exception for CRDs used by console for extensions, 2019-06-21, openshift#23231)'s "eliminating this exception in the near future", so I'm softening that to "may eventually". Extending system:authenticated is still not a great pattern to follow, but it may never be worth the time it would take the console team to build an alternative mechanism. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.13-e2e-aws-sdn-no-capabilities/1610257913278894080

… capability Clusters that disable the 'Console' capability are currently failing this test-case [1]: : [sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel] expand_less Run #0: Failed expand_less 3s { fail [github.com/openshift/origin/test/extended/authorization/rbac/groups_default_rules.go:229]: Jan 3 13:43:14.134: test data for system:authenticated has too many unnecessary permissions: {APIGroups:["console.openshift.io"], Resources:["consoleclidownloads"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleexternalloglinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolelinks"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolenotifications"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleplugins"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consolequickstarts"], Verbs:["get" "list" "watch"]} {APIGroups:["console.openshift.io"], Resources:["consoleyamlsamples"], Verbs:["get" "list" "watch"]} {APIGroups:["helm.openshift.io"], Resources:["helmchartrepositories"], Verbs:["get" "list"]} {APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]} Ginkgo exit error 1: exit with code 1} This commit uses the pattern that 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998) began using for CRDs to only add the console-linked rules when Console is enabled, and to only add the snapshot-linked rules when `CSISnapshot` is enabled. MicroShift won't have a ClusterVersion custom resource definition, but the test is already failing there [2], so this pivot doesn't break them any worse. Once they have a plan for how they would like to handle it, they can come back and make those changes in follow-up work. It has also been around three years since bb09b26 (Add system:authenticated exception for CRDs used by console for extensions, 2019-06-21, openshift#23231)'s "eliminating this exception in the near future", so I'm softening that to "may eventually". Extending system:authenticated is still not a great pattern to follow, but it may never be worth the time it would take the console team to build an alternative mechanism. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.13-e2e-aws-sdn-no-capabilities/1610257913278894080 [2]: openshift#27681 (comment)

openshift-ci bot requested review from smarterclayton and soltysh April 8, 2022 16:16

openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 8, 2022

honza changed the title ~~Bmh crd when capabilities none~~ cli: don't insist on metal3 CRDs being present when cluster capabilities are None Apr 8, 2022

honza force-pushed the bmh-crd-when-capabilities-none branch from 4e01590 to 3a4a875 Compare April 12, 2022 15:57

wking reviewed Apr 28, 2022

View reviewed changes

test/extended/cli/explain.go Outdated Show resolved Hide resolved

wking reviewed Apr 28, 2022

View reviewed changes

test/extended/cli/explain.go Outdated Show resolved Hide resolved

wking reviewed Apr 28, 2022

View reviewed changes

test/extended/cli/explain.go Show resolved Hide resolved

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022

honza force-pushed the bmh-crd-when-capabilities-none branch 2 times, most recently from 8a0d081 to 94f2262 Compare May 4, 2022 18:52

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022

honza force-pushed the bmh-crd-when-capabilities-none branch from 94f2262 to 6d1143a Compare May 25, 2022 13:11

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2022

honza changed the title ~~cli: don't insist on metal3 CRDs being present when cluster capabilities are None~~ Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None May 27, 2022

openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022

wking approved these changes May 27, 2022

View reviewed changes

openshift-ci bot assigned wking May 27, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022

openshift-merge-robot merged commit f0eef9f into openshift:master May 27, 2022

wking mentioned this pull request May 29, 2022

Bug 2091086: test/extended/cli/explain: Include OperatorHub CRD when 'marketplace' is enabled #27188

Merged

wking mentioned this pull request Jan 23, 2023

test/extended/authorization/rbac: Condition console RBAC on 'Console' capability #27681

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None #26998

Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None #26998

Uh oh!

honza commented Apr 8, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bparees commented Apr 29, 2022

Uh oh!

openshift-ci bot commented May 25, 2022 •

edited

Loading

Uh oh!

honza commented May 26, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

honza commented May 27, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

wking left a comment

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None #26998

Bug 2091086: cli: don't insist on metal3 CRDs being present when cluster capabilities are None #26998

Uh oh!

Conversation

honza commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bparees commented Apr 29, 2022

Uh oh!

openshift-ci bot commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honza commented May 26, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

honza commented May 27, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

openshift-ci bot commented May 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

honza commented Apr 8, 2022 •

edited

Loading

openshift-ci bot commented May 25, 2022 •

edited

Loading