-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Bug 2091086: test/extended/cli/explain: Include OperatorHub CRD when 'marketplace' is enabled #27188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2091086: test/extended/cli/explain: Include OperatorHub CRD when 'marketplace' is enabled #27188
Conversation
…condition Returning to 'master' pinning which we had until ccf5947 (go mod tidy && go mod vendor, 2022-01-12, openshift#26753), so I don't have to guess at the new pinned hash with: $ sed -i 's|\(openshift/api\) .*|\1 master|' go.mod And then updating the dependency (and apparently other floating dependencies) with: $ go get -u github.com/openshift/api $ go mod tidy $ go mod vendor $ git add -A go.* vendor using: $ go version go version go1.17.3 linux/amd64
|
@wking: This pull request references Bugzilla bug 2091086, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… is enabled Like 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix: rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (chore(modules): bump openshift/api for new operatorhub crd, 2022-05-02, operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the 'marketplace' cluster-version capability.
abf3b8e to
160ce18
Compare
njhale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, njhale, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2091086 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Like 6d1143a (#26998), but catching up to openshift/api@d905557541 (openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the
marketplacecluster-version capability. Plus an openshift/api vendor bump to bring in theClusterVersionCapabilityMarketplaceconstant for that capability).