Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented May 29, 2022

Like 6d1143a (#26998), but catching up to openshift/api@d905557541 (openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the marketplace cluster-version capability. Plus an openshift/api vendor bump to bring in the ClusterVersionCapabilityMarketplace constant for that capability).

…condition

Returning to 'master' pinning which we had until ccf5947 (go mod
tidy && go mod vendor, 2022-01-12, openshift#26753), so I don't have to guess
at the new pinned hash with:

  $ sed -i 's|\(openshift/api\) .*|\1 master|' go.mod

And then updating the dependency (and apparently other floating
dependencies) with:

  $ go get -u github.com/openshift/api
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* vendor

using:

  $ go version
  go version go1.17.3 linux/amd64
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2022

@wking: This pull request references Bugzilla bug 2091086, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 2091086: test/extended/cli/explain: Include OperatorHub CRD when 'marketplace' is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and soltysh May 29, 2022 23:13
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 29, 2022
… is enabled

Like 6d1143a (cli: remove metal3 CRDs when capabilities are none,
2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix:
rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178)
and operator-framework/operator-marketplace@eca17739ed
(chore(modules): bump openshift/api for new operatorhub crd,
2022-05-02, operator-framework/operator-marketplace#472) dancing the
OperatorHub CRD over to the marketplace operator, and making it part
of the 'marketplace' cluster-version capability.
@wking wking force-pushed the operatorhubs-depends-on-marketplace branch from abf3b8e to 160ce18 Compare June 1, 2022 13:46
Copy link
Contributor

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(although I'm not one of the reviewers or approvers for this directory)

cc @bparees

@njhale
Copy link
Contributor

njhale commented Jun 1, 2022

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@bparees
Copy link
Contributor

bparees commented Jun 1, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, njhale, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 56121c4 and 8 for PR HEAD 160ce18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 56121c4 and 7 for PR HEAD 160ce18 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade 160ce18 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 160ce18 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-single-node 160ce18 link false /test e2e-aws-single-node
ci/prow/e2e-aws-csi 160ce18 link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b8672b8 into openshift:master Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@wking: All pull requests linked via external trackers have merged:

Bugzilla bug 2091086 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2091086: test/extended/cli/explain: Include OperatorHub CRD when 'marketplace' is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the operatorhubs-depends-on-marketplace branch June 8, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants