USHIFT-285: Add MicroShift version getter to framework #27345

pacevedom · 2022-08-05T15:47:46Z

Add a function to determine if the cluster is a MicroShift instance.

openshift-ci · 2022-08-05T15:47:50Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

test/extended/util/framework.go

pacevedom · 2022-08-17T10:56:12Z

/retest-required

pacevedom · 2022-08-17T14:30:58Z

/retest-required

pacevedom · 2022-08-17T21:35:44Z

/retest-required

pacevedom · 2022-08-18T07:12:34Z

/retest-required

pacevedom · 2022-08-18T12:23:27Z

/retest-required

dhellmann · 2022-08-18T15:16:12Z

The implementation looks good. Are those CI job failures related?

pacevedom · 2022-08-18T15:29:04Z

The implementation looks good. Are those CI job failures related?

Not really, this function is not used yet. Anyway I tmeporarily removed the call from GetControlPlaneTopology to inspect if we might enable bad code paths in other tests.

pacevedom · 2022-08-18T19:14:40Z

/retest-required

dhellmann

One nit that can be addressed later.

/approve

test/extended/util/framework.go

ggiguash · 2022-08-31T09:09:02Z

/retitle USHIFT-285: Add MicroShift version getter to framework

dhellmann

/lgtm

test/extended/util/framework.go

pacevedom · 2022-08-31T15:00:09Z

/assign @knobunc

pacevedom · 2022-09-01T08:00:12Z

/retest-required

pacevedom · 2022-09-01T10:43:03Z

/retest-required

pacevedom · 2022-09-02T09:28:58Z

/retest-required

ggiguash · 2022-09-04T07:29:39Z

/retest-required

test/extended/util/framework.go

pacevedom · 2022-09-09T06:11:41Z

/assign @ingvagabund

ingvagabund · 2022-09-19T16:05:03Z

test/extended/util/framework.go

+	defer microShiftMutex.Unlock()
+
+	if microShiftVersion == "" {
+		cm, err := ocClient.AdminKubeClient().CoreV1().ConfigMaps("kube-public").Get(context.Background(), "microshift-version", metav1.GetOptions{})


I don't see any microshift-version CM under kube-public NS in ocp 4.12 vanilla cluster. Meaning get request for the CM will get requested every time a test invoking IsMicroShiftDeployment gets running. What about introducing another microShiftVersionCMNotFound variable and setting it to false when err != nil && apierrors.IsNotFound(err)? Then if microShiftVersionCMNotFound { return "" } before if microShiftVersion == "" {? Or similar mechanism against re-getting microshift-version` CM.

openshift-ci · 2022-09-21T12:48:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhellmann, pacevedom
Once this PR has been reviewed and has the lgtm label, please ask for approval from knobunc by writing /assign @knobunc in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

test/extended/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deads2k · 2022-09-21T17:02:17Z

/hold

let's see where this is needed instead of using existing external signals before merging.

openshift-ci · 2022-09-22T09:11:08Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2022-09-22T12:43:49Z

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node-upgrade	`0225280`	link	false	`/test e2e-aws-single-node-upgrade`
ci/prow/e2e-aws-single-node	`0225280`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-agnostic-cmd	`0225280`	link	false	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-ovn-single-node-upgrade	`648b238`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-aws-ovn-serial	`648b238`	link	true	`/test e2e-aws-ovn-serial`
ci/prow/e2e-gcp-ovn-upgrade	`648b238`	link	true	`/test e2e-gcp-ovn-upgrade`
ci/prow/e2e-aws-ovn-single-node	`648b238`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-aws-ovn-single-node-serial	`648b238`	link	false	`/test e2e-aws-ovn-single-node-serial`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pacevedom · 2022-09-23T13:17:28Z

/hold

let's see where this is needed instead of using existing external signals before merging.

So it's these tests now:

"[sig-auth][Feature:PodSecurity] restricted-v2 SCC should mutate empty securityContext to match restricted PSa profile [Suite:openshift/conformance/parallel]"
"[sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel]"
"[sig-coreos] [Conformance] CoreOS bootimages TestBootimagesPresent [Suite:openshift/conformance/parallel/minimal]"
"[sig-devex][Feature:OpenShiftControllerManager] TestAutomaticCreationOfPullSecrets [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]"
"[sig-devex][Feature:OpenShiftControllerManager] TestDockercfgTokenDeletedController [Suite:openshift/conformance/parallel]"
"[sig-imageregistry][Feature:ImageInfo] Image info should display information about images [Skipped:Disconnected] [Suite:openshift/conformance/parallel]"
"[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router converges when multiple routers are writing conflicting status [Suite:openshift/conformance/parallel]"
"[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router converges when multiple routers are writing status [Suite:openshift/conformance/parallel]"

More to come as we create/modify specific tests for microshift, I would say.

pacevedom · 2022-09-26T13:26:34Z

Not needed anymore, as we look for dependencies in each test.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2022

dhellmann reviewed Aug 5, 2022

View reviewed changes

test/extended/util/framework.go Outdated Show resolved Hide resolved

pacevedom marked this pull request as ready for review August 16, 2022 16:08

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022

openshift-ci bot requested review from gabemontero and knobunc August 16, 2022 16:09

pacevedom force-pushed the microshift branch from 779fe91 to 6c85ccb Compare August 17, 2022 07:03

pacevedom force-pushed the microshift branch from 6c85ccb to 53afdac Compare August 17, 2022 15:51

pacevedom force-pushed the microshift branch from 53afdac to 0225280 Compare August 18, 2022 15:27

dhellmann reviewed Aug 29, 2022

View reviewed changes

test/extended/util/framework.go Outdated Show resolved Hide resolved

openshift-ci bot changed the title ~~Add microshift version getter to framework~~ USHIFT-285: Add MicroShift version getter to framework Aug 31, 2022

dhellmann reviewed Aug 31, 2022

View reviewed changes

test/extended/util/framework.go Outdated Show resolved Hide resolved

openshift-ci bot assigned dhellmann Aug 31, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022

openshift-ci bot assigned knobunc Aug 31, 2022

aojea reviewed Sep 6, 2022

View reviewed changes

test/extended/util/framework.go Show resolved Hide resolved

openshift-ci bot assigned ingvagabund Sep 9, 2022

This was referenced Sep 13, 2022

USHIFT-345: MicroShift: skip sig-arch tests #27407

Closed

USHIFT-350: MicroShift: skip sig-coreos tests #27400

Merged

USHIFT-348: microshift: skip and fix sig-cli tests #27389

Closed

USHIFT-346: MicroShift: skip sig-auth tests #27404

Merged

ingvagabund suggested changes Sep 21, 2022

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022

Add microshift version getter to framework

648b238

pacevedom force-pushed the microshift branch from 0225280 to 648b238 Compare September 22, 2022 09:11

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022

pacevedom closed this Sep 26, 2022

pacevedom deleted the microshift branch September 26, 2022 13:26

USHIFT-285: Add MicroShift version getter to framework #27345

USHIFT-285: Add MicroShift version getter to framework #27345

Uh oh!

Conversation

pacevedom commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 5, 2022

Uh oh!

Uh oh!

pacevedom commented Aug 17, 2022

Uh oh!

pacevedom commented Aug 17, 2022

Uh oh!

pacevedom commented Aug 17, 2022

Uh oh!

pacevedom commented Aug 18, 2022

Uh oh!

pacevedom commented Aug 18, 2022

Uh oh!

dhellmann commented Aug 18, 2022

Uh oh!

pacevedom commented Aug 18, 2022

Uh oh!

pacevedom commented Aug 18, 2022

Uh oh!

dhellmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ggiguash commented Aug 31, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pacevedom commented Aug 31, 2022

Uh oh!

pacevedom commented Sep 1, 2022

Uh oh!

pacevedom commented Sep 1, 2022

Uh oh!

pacevedom commented Sep 2, 2022

Uh oh!

ggiguash commented Sep 4, 2022

Uh oh!

Uh oh!

pacevedom commented Sep 9, 2022

Uh oh!

ingvagabund Sep 19, 2022

Choose a reason for hiding this comment

Uh oh!

pacevedom Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 21, 2022

Uh oh!

deads2k commented Sep 21, 2022

Uh oh!

openshift-ci bot commented Sep 22, 2022

Uh oh!

openshift-ci bot commented Sep 22, 2022

Uh oh!

pacevedom commented Sep 23, 2022

Uh oh!

pacevedom commented Sep 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pacevedom commented Aug 5, 2022 •

edited

Loading

ggiguash commented Aug 31, 2022 •

edited by openshift-ci bot

Loading