Skip to content

USHIFT-350: MicroShift: skip sig-coreos tests #27400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 30, 2022
Merged

USHIFT-350: MicroShift: skip sig-coreos tests #27400

openshift-merge-robot merged 1 commit into from
Sep 30, 2022

Conversation

@pacevedom
Copy link
Contributor

@pacevedom pacevedom commented Sep 6, 2022

No description provided.

deads2k
deads2k reviewed Sep 6, 2022
View reviewed changes
test/extended/coreos/coreos.go Outdated
}
})

g.It("TestBootimagesPresent", func() {
Copy link
Contributor

@deads2k deads2k Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these present in hypershift? I don't know what they are, but if every other form-factor of OCP has these, why shouldn't microshift?

Copy link
Contributor Author

@pacevedom pacevedom Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the RHCOS images for the node and where to get them depending on the platform. Microshift does not run on RHCOS and does not have machine config operator either, so this test may be skipped.

@pacevedom
Copy link
Contributor Author

pacevedom commented Sep 13, 2022

/hold
Need to rework.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@pacevedom
Copy link
Contributor Author

pacevedom commented Sep 14, 2022

/unhold
Ready for review. Depends on #27345
/assign @ingvagabund

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@pacevedom
Copy link
Contributor Author

pacevedom commented Sep 23, 2022

/retest-required

@pacevedom
Copy link
Contributor Author

pacevedom commented Sep 23, 2022

/hold
Need to get of microshift checks

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@pacevedom
Copy link
Contributor Author

pacevedom commented Sep 23, 2022

/unhold
Swapped the microshift check for MCO CRDs presence, as the test is based in resources this operator creates.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
ingvagabund
ingvagabund reviewed Sep 29, 2022
View reviewed changes
test/extended/coreos/coreos.go
oc := exutil.NewCLIWithoutNamespace("coreos")
g.It("TestBootimagesPresent", func() {

g.It("TestBootimagesPresent [apigroup:machineconfiguration.openshift.io]", func() {
Copy link
Member

@ingvagabund ingvagabund Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27400/pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2/1573331257285152768 the test is still running

Copy link
Contributor Author

@pacevedom pacevedom Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from the CRD that MCO installs. If its not there then there is certainly no MCO.

@ingvagabund
Copy link
Member

ingvagabund commented Sep 29, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
soltysh
soltysh approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, pacevedom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2022

/retest-required

Remaining retests: 0 against base HEAD e25bd15 and 2 for PR HEAD 61595d5 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2022

/retest-required

Remaining retests: 0 against base HEAD 8767b07 and 1 for PR HEAD 61595d5 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2022

/retest-required

Remaining retests: 0 against base HEAD 6c3592b and 0 for PR HEAD 61595d5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022 •
edited
Loading

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 61595d5 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-rt-upgrade 61595d5 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade 61595d5 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacevedom
Copy link
Contributor Author

pacevedom commented Sep 30, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit ef6536b into openshift:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@mfojtik mfojtik Awaiting requested review from mfojtik

+2 more reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pacevedom @ingvagabund @openshift-ci-robot @soltysh @deads2k @openshift-merge-robot