Skip to content

WIP: migrating to ginkgo v2 #27376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bparees wants to merge 32 commits into from
Closed

WIP: migrating to ginkgo v2 #27376

bparees wants to merge 32 commits into from

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Aug 24, 2022

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval by writing /assign @sttts in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label Aug 24, 2022
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Aug 24, 2022
@bparees bparees force-pushed the ginkgov2.rebase branch 4 times, most recently from bc7953c to ae6af71 Compare August 25, 2022 19:51
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2022
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 25, 2022

@bparees: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees force-pushed the ginkgov2.rebase branch 2 times, most recently from c4a0c3c to 930c546 Compare August 26, 2022 19:38
bparees added 16 commits August 26, 2022 16:32
@bparees
REBASE: vendor ginkgo v2 and maciej's k/k branch
33948c8
@bparees
CARRY: add a no-agent variant of loadconfig so we can invoke loadconfig
fe6e30c 
when we're not running tests

Note: i don't think the existing LoadConfig will panic anymore if no
test is running, so we probably don't actually need this.  I think the
current version of LoadConfig() will just leave the user agent empty if
no test is running.
@bparees
REBASE: Switch to imports to ginkgo v2
4d72967
@bparees
REBASE: remove podsecuritypolicy ref in test (removed from upstream k8s)
5f4b301
@bparees
REBASE: Replace use of EchoServer image (image went away in upstream
b1653ef 
k8s)
@bparees
REBASE: Remove SkipPrivilegedPSPBinding config ref (setting went away in
99815a3 
upstream k8s)
@bparees
REFACTOR: Adapt ginkgo spec wrapper type
5100416
@bparees
REFACTOR: adapt to v2 by migrating use of extensions/table package
c554e92
@bparees
REFACTOR: adapting cmd_runtest.go to v2
1be5c29
@bparees
REFACTOR: adapt to v2 by migrating use of config.GinkgoConfig to gink…
b868d4e 
…go.GinkgoConfiguration()
@bparees
REBASE: switch image mapping index type from int to k8s.ImageID
91bdf83
@bparees
REFACTOR: Appears to be dead code, remove it so it doesn't confuse
91f1e4b 
people who are trying to understand how we run tests
@bparees
REFACTOR: fix up usage of config.GinkgoConfig
8e15e05
@bparees
REFACTOR: clear before/aftersuite nodes
5815c93
@bparees
REBASE: refactor code to use carried patch version of LoadConfigNoAgent
e7c972e 
See previous CARRY commit.  Should be able to convert these to pure
LoadConfig() calls, i don't think it will panic anymore.
@bparees
REBASE: update the allowed images based on changes to upstream image
6bed068 
use, this commit needs examination, i have many questions about how this
is intended to work and why we listed some of the images we listed here.
bparees added 16 commits August 26, 2022 16:32
@bparees
REFACTOR: reworking how walking tests works with respect to checking
5632643 
code locations
@bparees
REFACTOR: append test names w/ annotations at runtime for run and
8c11a5d 
run-test
@bparees
REFACTOR: adjust to we avoid running before/aftersuite nodes
ba4e202
@bparees
HACK: massive hacks to run a single spec and report result. Needs
f8a2a7e 
serious revisiting.
@bparees
REFACTOR: wrap ginkgo spec so we can pass it to gingko v2's run spec
a2c4865 
method
@bparees
REFACTOR: eliminate references to "[Top Level]" which was a v1 thing,
44cfb0f 
some other small cleanup
@bparees
REFACTOR: emit spec progress during reporting
18842e4
@bparees
REFACTOR: post origin rebase merge cleanup
467f903
@bparees
REFACTOR: fix up go vet error
1a3e026
@bparees
REFACTOR: set nocolor to true to match existing behavior
ca95f8b
@bparees
REFACTOR: remove more reporting logic that is no longer needed
15171f2
@bparees
REFACTOR: randomize the test specs before running them (matches old
f0d1f58 
behavior)
@bparees
CARRY: fix up k8s annotation generator logic
2892ff5
@bparees
REFACTOR: simplify annotation generator+rules
6291caf
@bparees
REFACTOR: hack/update-generated.sh
07cd492
@bparees
REFACTOR: reduce memory allocations by only creating the regex once
1cf6deb
@soltysh soltysh mentioned this pull request Sep 9, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

@bparees: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-upgrade 1cf6deb link true /test e2e-gcp-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 1cf6deb link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-csi 1cf6deb link false /test e2e-aws-csi
ci/prow/e2e-aws-single-node 1cf6deb link false /test e2e-aws-single-node
ci/prow/verify 1cf6deb link true /test verify
ci/prow/e2e-gcp-csi 1cf6deb link false /test e2e-gcp-csi
ci/prow/e2e-gcp-builds 1cf6deb link true /test e2e-gcp-builds
ci/prow/lint 1cf6deb link true /test lint
ci/prow/e2e-gcp-image-ecosystem 1cf6deb link true /test e2e-gcp-image-ecosystem
ci/prow/e2e-aws-fips 1cf6deb link true /test e2e-aws-fips
ci/prow/e2e-aws-cgroupsv2 1cf6deb link false /test e2e-aws-cgroupsv2
ci/prow/e2e-aws-serial 1cf6deb link true /test e2e-aws-serial
ci/prow/images 1cf6deb link true /test images
ci/prow/e2e-aws-image-registry 1cf6deb link true /test e2e-aws-image-registry
ci/prow/verify-deps 1cf6deb link true /test verify-deps
ci/prow/e2e-aws-single-node-upgrade 1cf6deb link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 1cf6deb link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-agnostic-cmd 1cf6deb link false /test e2e-agnostic-cmd
ci/prow/e2e-gcp 1cf6deb link true /test e2e-gcp
ci/prow/e2e-gcp-ovn-upgrade 1cf6deb link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-fips 1cf6deb link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial 1cf6deb link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn 1cf6deb link true /test e2e-gcp-ovn
ci/prow/unit 1cf6deb link true /test unit
ci/prow/e2e-gcp-ovn-image-ecosystem 1cf6deb link true /test e2e-gcp-ovn-image-ecosystem
ci/prow/e2e-gcp-ovn-builds 1cf6deb link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-image-registry 1cf6deb link true /test e2e-aws-ovn-image-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 3, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023
@bparees bparees removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023
@bparees bparees closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. e2e-images-update Related to images used by e2e tests needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bparees @openshift-merge-robot @openshift-bot