Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Oct 10, 2022

Reverts ##27444 ; tracked by OCPBUGS-2155

Per TRT policy, we are reverting this breaking change to get ci and/or nightly payloads flowing again. This change made this test run in [Suite:openshift/conformance/parallel] instead of the intended new etcd suite. It's causing jobs to fail, so I'm going to have to revert this change.

To unrevert this revert, revert this PR, and layer an additional separate commit on top that addresses the problem, and ensure the test does not run in either serial or parallel conformance runs.

CC: @hasbro17

@stbenjam stbenjam marked this pull request as ready for review October 10, 2022 13:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stbenjam stbenjam changed the title Revert "Add etcd vertical scaling test suite" OCPBUGS-2155: Revert "Add etcd vertical scaling test suite" Oct 10, 2022
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 10, 2022
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-2155, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts ##27444 ; tracked by OCPBUGS-2155

Per TRT policy, we are reverting this breaking change to get ci and/or nightly payloads flowing again. This change made this test run in [Suite:openshift/conformance/parallel] instead of the intended new etcd suite. It's causing jobs to fail, so I'm going to have to revert this change.

To unrevert this revert, revert this PR, and layer an additional separate commit on top that addresses the problem, and ensure the test does not run in neither serial nor regular conformance runs.

CC: @hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 10, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
@openshift-ci openshift-ci bot requested review from c3d, csrwng and geliu2016 October 10, 2022 13:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@DennisPeriquet
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-2155, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

Details

In response to this:

Reverts ##27444 ; tracked by OCPBUGS-2155

Per TRT policy, we are reverting this breaking change to get ci and/or nightly payloads flowing again. This change made this test run in [Suite:openshift/conformance/parallel] instead of the intended new etcd suite. It's causing jobs to fail, so I'm going to have to revert this change.

To unrevert this revert, revert this PR, and layer an additional separate commit on top that addresses the problem, and ensure the test does not run in either serial or regular conformance runs.

CC: @hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Oct 10, 2022

This looks low risk to me as long it was a clean revert. even if it wasn't HEAD

@stbenjam
Copy link
Member Author

/skip
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade

Forcing as revert is clean and we need to get back to a healthy state.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

/skip
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade

Forcing as revert is clean and we need to get back to a healthy state.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

/override ci/prow/e2e-gcp-builds

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-builds

Details

In response to this:

/override ci/prow/e2e-gcp-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-2155, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

Details

In response to this:

Reverts ##27444 ; tracked by OCPBUGS-2155

Per TRT policy, we are reverting this breaking change to get ci and/or nightly payloads flowing again. This change made this test run in [Suite:openshift/conformance/parallel] instead of the intended new etcd suite. It's causing jobs to fail, so I'm going to have to revert this change.

To unrevert this revert, revert this PR, and layer an additional separate commit on top that addresses the problem, and ensure the test does not run in either serial or parallel conformance runs.

CC: @hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 23156fc into openshift:master Oct 10, 2022
@openshift-ci-robot
Copy link

@stbenjam: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2155 has been moved to the MODIFIED state.

Details

In response to this:

Reverts ##27444 ; tracked by OCPBUGS-2155

Per TRT policy, we are reverting this breaking change to get ci and/or nightly payloads flowing again. This change made this test run in [Suite:openshift/conformance/parallel] instead of the intended new etcd suite. It's causing jobs to fail, so I'm going to have to revert this change.

To unrevert this revert, revert this PR, and layer an additional separate commit on top that addresses the problem, and ensure the test does not run in either serial or parallel conformance runs.

CC: @hasbro17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the revert-27444-move-etcd-scaling-test branch October 10, 2022 14:29
stbenjam added a commit to stbenjam/origin that referenced this pull request Oct 10, 2022
…-move-etcd-scaling-test"

This reverts commit 23156fc, reversing
changes made to d2d4566.
@geliu2016
Copy link

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@geliu2016: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam added a commit to stbenjam/origin that referenced this pull request Oct 13, 2022
…-move-etcd-scaling-test"

This reverts commit 23156fc, reversing
changes made to d2d4566.
stbenjam added a commit to stbenjam/origin that referenced this pull request Oct 26, 2022
…-move-etcd-scaling-test"

This reverts commit 23156fc, reversing
changes made to d2d4566.
stbenjam added a commit to stbenjam/origin that referenced this pull request Oct 26, 2022
…-move-etcd-scaling-test"

This reverts commit 23156fc, reversing
changes made to d2d4566.
tjungblu pushed a commit to tjungblu/origin that referenced this pull request Apr 11, 2023
…-move-etcd-scaling-test"

This reverts commit 23156fc, reversing
changes made to d2d4566.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants