Unrevert etcd vertical scaling test #27464

stbenjam · 2022-10-10T16:27:52Z

I had to revert #27463 because the etcd tes was mistakenly running in all parallel conformance jobs. In order to make this test only part of the etcd scaling test, we need to mark it so -- but this requires a change to openshift/kubernetes to allow that behavior.

stbenjam · 2022-10-10T16:28:27Z

/hold

Needs openshift/kubernetes#1388

hasbro17 · 2022-10-10T17:20:21Z

test/extended/util/annotate/generated/zz_generated.annotations.go

 	"[Top Level] [sig-etcd][Feature:DisasterRecovery][Disruptive] [Feature:EtcdRecovery] Cluster should restore itself after quorum loss [apigroup:machine.openshift.io][apigroup:operator.openshift.io]": "[Feature:EtcdRecovery] Cluster should restore itself after quorum loss [apigroup:machine.openshift.io][apigroup:operator.openshift.io] [Serial]",

-	"[Top Level] [sig-etcd][Serial] etcd [apigroup:config.openshift.io] is able to vertically scale up and down with a single node [Timeout:60m][apigroup:machine.openshift.io]": "is able to vertically scale up and down with a single node [Timeout:60m][apigroup:machine.openshift.io] [Suite:openshift/conformance/serial]",
+	"[Top Level] [sig-etcd][Feature:EtcdVerticalScaling] etcd [apigroup:config.openshift.io] is able to vertically scale up and down with a single node [Timeout:60m][apigroup:machine.openshift.io]": "is able to vertically scale up and down with a single node [Timeout:60m][apigroup:machine.openshift.io] [Suite:openshift/conformance/parallel]",


Re-run hack/update-generated.sh?

Needs openshift/kubernetes#1388 first

stbenjam · 2022-10-18T13:03:30Z

openshift/kubernetes#1388 merged, now we just need it in origin. 1.25 rebase needs to land, and then I can vendor that change

hasbro17 · 2022-10-24T17:07:44Z

@stbenjam Just wanted to confirm what to track: is this depending on the 1.25 rebase in origin(#27490) or openshift/kubernetes(openshift/kubernetes#1380)?

stbenjam · 2022-10-26T12:58:42Z

My commit to openshift/kubernetes needs to get vendored here in origin openshift/kubernetes#1388

I don't think Maciej's rebase includes it. Looks like #27490 just landed this morning, I'll put together the next vendoring PR

…-move-etcd-scaling-test" This reverts commit 23156fc, reversing changes made to d2d4566.

stbenjam · 2022-10-26T18:30:32Z

My commit to openshift/kubernetes needs to get vendored here in origin openshift/kubernetes#1388

I don't think Maciej's rebase includes it. Looks like #27490 just landed this morning, I'll put together the next vendoring PR

Ah he pulled in the change I needed, so this is much simpler. This should be good now, etcd scale test has the right suite set on it.

hasbro17 · 2022-10-26T19:04:25Z

/lgtm

openshift-ci · 2022-10-26T19:04:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~cmd/OWNERS~~ [stbenjam]
~~test/extended/etcd/OWNERS~~ [hasbro17,stbenjam]
~~test/extended/util/annotate/generated/OWNERS~~ [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2022-10-27T06:47:42Z

/retest-required

damdo · 2022-10-27T13:38:24Z

Is this unhold-able now? @stbenjam
Thanks!

stbenjam · 2022-10-27T14:45:58Z

Yup!

/hold cancel

damdo · 2022-10-27T17:52:27Z

/retest-required

stbenjam · 2022-10-27T17:57:35Z

Ugh we might have to revert the 1.25 rebase because of TRT-643

stbenjam · 2022-10-27T17:57:44Z

/hold

hasbro17 · 2022-11-08T17:50:07Z

@stbenjam Is this good to go now that we have 1.25 merged again (#27526). Also happy to take over and rebase in case you're busy with other work.

hasbro17 · 2022-11-08T17:52:01Z

Hmm, guess we don't need a rebase anymore.
/retest-required

openshift-ci · 2022-11-08T20:12:49Z

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-csi	`8a09f33`	link	false	`/test e2e-gcp-csi`
ci/prow/e2e-aws-csi	`8a09f33`	link	false	`/test e2e-aws-csi`
ci/prow/e2e-aws-ovn-single-node	`8a09f33`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-metal-ipi-ovn-ipv6	`8a09f33`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-aws-ovn-single-node-serial	`8a09f33`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-aws-ovn-single-node-upgrade	`8a09f33`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-openstack-ovn	`8a09f33`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-metal-ipi-sdn	`8a09f33`	link	false	`/test e2e-metal-ipi-sdn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stbenjam · 2022-11-09T01:49:47Z

/hold cancel

stbenjam · 2022-11-09T01:50:20Z

/override ci/prow/e2e-gcp-ovn-image-ecosystem

openshift-ci · 2022-11-09T01:50:27Z

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn-image-ecosystem

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-image-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022

openshift-ci bot requested review from beekhof and hasbro17 October 10, 2022 16:28

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022

hasbro17 reviewed Oct 10, 2022

View reviewed changes

stbenjam force-pushed the fix-etcd-suite branch from 384670d to 7b12a28 Compare October 13, 2022 10:52

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022

openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 24, 2022

stbenjam force-pushed the fix-etcd-suite branch from 7b12a28 to 61a852c Compare October 26, 2022 15:05

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2022

openshift-ci bot added the vendor-update Touching vendor dir or related files label Oct 26, 2022

stbenjam force-pushed the fix-etcd-suite branch from 61a852c to b651f62 Compare October 26, 2022 18:25

stbenjam added 2 commits October 26, 2022 14:26

Revert "Merge pull request openshift#27463 from stbenjam/revert-27444…

73e60be

…-move-etcd-scaling-test" This reverts commit 23156fc, reversing changes made to d2d4566.

Add suite name to etcd test

8a09f33

stbenjam force-pushed the fix-etcd-suite branch from b651f62 to 8a09f33 Compare October 26, 2022 18:29

openshift-ci bot assigned hasbro17 Oct 26, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2022

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2022

openshift-merge-robot merged commit d9a5ade into openshift:master Nov 9, 2022

Unrevert etcd vertical scaling test #27464

Unrevert etcd vertical scaling test #27464

Uh oh!

Conversation

stbenjam commented Oct 10, 2022

Uh oh!

stbenjam commented Oct 10, 2022

Uh oh!

hasbro17 Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stbenjam Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stbenjam commented Oct 18, 2022

Uh oh!

hasbro17 commented Oct 24, 2022

Uh oh!

stbenjam commented Oct 26, 2022

Uh oh!

stbenjam commented Oct 26, 2022

Uh oh!

hasbro17 commented Oct 26, 2022

Uh oh!

openshift-ci bot commented Oct 26, 2022

Uh oh!

damdo commented Oct 27, 2022

Uh oh!

damdo commented Oct 27, 2022

Uh oh!

stbenjam commented Oct 27, 2022

Uh oh!

damdo commented Oct 27, 2022

Uh oh!

stbenjam commented Oct 27, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stbenjam commented Oct 27, 2022

Uh oh!

hasbro17 commented Nov 8, 2022

Uh oh!

hasbro17 commented Nov 8, 2022

Uh oh!

openshift-ci bot commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stbenjam commented Nov 9, 2022

Uh oh!

stbenjam commented Nov 9, 2022

Uh oh!

openshift-ci bot commented Nov 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stbenjam commented Oct 27, 2022 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Nov 8, 2022 •

edited

Loading