Skip to content

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Oct 24, 2022

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2022
@soltysh
Copy link
Contributor Author

soltysh commented Oct 24, 2022

/payload 4.12 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@soltysh: trigger 4 job(s) of type blocking for the ci release of OCP 4.12

  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/37f00a50-53a9-11ed-8a5b-47bb2f715871-0

@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 24, 2022
@stlaz
Copy link
Contributor

stlaz commented Oct 24, 2022

/test lint

@soltysh
Copy link
Contributor Author

soltysh commented Oct 24, 2022

/retest-required

@soltysh
Copy link
Contributor Author

soltysh commented Oct 24, 2022

/payload 4.12 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@soltysh: trigger 4 job(s) of type blocking for the ci release of OCP 4.12

  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4ff36730-53d3-11ed-8ada-cae838cd733b-0

@stbenjam
Copy link
Member

/payload 4.12 ci blocking

Retesting for confirmation. We don't want to reintroduce this just yet since we got a streak of 6 rejected payloads and then it stopped once this was reverted, but the above payload command did succeed. The problems could've been something with infra... but I can't tell for sure from the logs.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

@stbenjam: trigger 4 job(s) of type blocking for the ci release of OCP 4.12

  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0b819600-5467-11ed-8b02-332ffce0dd4e-0

@stbenjam
Copy link
Member

stbenjam commented Oct 25, 2022

2x passed payload jobs. This is good to land after fixing the conflict.

The only thing I can find in the failed jobs over the weekend is some failed ImagePullBackOffs, which must have contributed to the timeouts.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2022
bparees and others added 12 commits October 25, 2022 21:49
ExecuteTest was never executed anywhere, so not to confuse users how we
run tests this is being removed.
setTestExclusion was matching against k8s.io/kubernetes/test/e2e/apps/disruption.go
suffix, but since a while now, all packages vendored with go.mod report
as: k8s.io/kubernetes@<version>/test/e2e/apps/disruption.go so this
wasn't doing anything.
registry.k8s.io/pause:3.8 has problems with uncompressed windows
layers which are not accepted by quay.io
…age tests

The WaitForPod* methods has changed in kubernetes/kubernetes#109704
currently they are very strict about their expected state, so a quick
run, like in most cases in these tests where we just print usage and
complete won't likely catch running pod, so instead it's best to wait
for it to finish.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2022
@stbenjam
Copy link
Member

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanchezl
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit de3cdf6 into openshift:master Oct 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn 209e426 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-csi 209e426 link false /test e2e-aws-csi
ci/prow/e2e-metal-ipi-ovn-ipv6 209e426 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-serial 209e426 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-csi 209e426 link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh soltysh deleted the rebase-1.25.0 branch October 26, 2022 10:53
stbenjam added a commit to stbenjam/origin that referenced this pull request Oct 27, 2022
@stbenjam stbenjam mentioned this pull request Oct 27, 2022
@gnufied
Copy link
Member

gnufied commented Oct 27, 2022

This also broke all CSI tests. I can't even do a --dry-run:

╰─redhat/vmware-vsphere-csi-driver-operator> TEST_CSI_DRIVER_FILES=./test/e2e/manifest.yaml ~/redhat/origin/openshift-tests run --dry-run openshift/csi
Oct 27 15:07:47.205: INFO: Driver loaded from path [./test/e2e/manifest.yaml]: &{DriverInfo:{Name:csi.vsphere.vmware.com InTreePluginName: FeatureTag: MaxFileSize:0 SupportedSizeRange:{Max:64Ti Min:1Gi} SupportedFsType:map[:{} ext4:{} xfs:{}] SupportedMountOption:map[dirsync:{}] RequiredMountOption:map[] Capabilities:map[block:true controllerExpansion:true exec:true fsGroup:true nodeExpansion:true offlineExpansion:true onlineExpansion:true persistence:true snapshotDataSource:false volumeLimits:false] RequiredAccessModes:[] TopologyKeys:[] NumAllowedTopologies:0 StressTestOptions:<nil> VolumeSnapshotStressTestOptions:<nil> PerformanceTestOptions:<nil>} StorageClass:{FromName:false FromFile: FromExistingClassName:thin-csi} SnapshotClass:{FromName:true FromFile: FromExistingClassName:} InlineVolumes:[] ClientNodeName: Timeouts:map[]}
Oct 27 15:07:47.220: INFO: Enabling in-tree volume drivers
panic: unable to find test External Storage [Driver: csi.vsphere.vmware.com] [Testpattern: Dynamic PV (default fs)] capacity provides storage capacity information

goroutine 1 [running]:
github.com/openshift/origin/pkg/test/ginkgo.testsForSuite.func1({0xc0055eccf0, 0x87}, {0x9366620, 0xc00564eee0})
        github.com/openshift/origin/pkg/test/ginkgo/ginkgo.go:23 +0x234
github.com/onsi/ginkgo/v2/internal.(*Suite).WalkTests(0xc0002de000, 0xc002efc9f0)
        github.com/onsi/ginkgo/v2@v2.1.5-0.20220909190140-b488ab12695a/internal/suite_patch.go:26 +0x12b
github.com/openshift/origin/pkg/test/ginkgo.testsForSuite()
        github.com/openshift/origin/pkg/test/ginkgo/ginkgo.go:19 +0xb7
github.com/openshift/origin/pkg/test/ginkgo.(*Options).Run(0xc0001ce540, 0xc4ab400, {0x8649c87, 0xf})
        github.com/openshift/origin/pkg/test/ginkgo/cmd_runsuite.go:153 +0x185
main.newRunCommand.func1.1()
        github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:320 +0x2d4
main.mirrorToFile(0x3a4b711?, 0xc0018c8000?)
        github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:457 +0x102
main.newRunCommand.func1(0xc001892c80?, {0xc0015cf9c0?, 0x2?, 0x2?})
        github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:301 +0x5c
github.com/spf13/cobra.(*Command).execute(0xc001892c80, {0xc0015cf9a0, 0x2, 0x2})
        github.com/spf13/cobra@v1.4.0/command.go:856 +0x67c
github.com/spf13/cobra.(*Command).ExecuteC(0xc001892a00)
        github.com/spf13/cobra@v1.4.0/command.go:974 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.4.0/command.go:902
main.main.func1(0xc0018c8600?)
        github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:93 +0x8a
main.main()
        github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:94 +0x476
╭─ lakealder☯  ⸙-1.19.1   openshift:master                                         

stbenjam added a commit to stbenjam/origin that referenced this pull request Oct 28, 2022
@soltysh soltysh restored the rebase-1.25.0 branch October 30, 2022 05:57
bparees added a commit to bparees/origin that referenced this pull request Nov 1, 2022
bparees added a commit to bparees/origin that referenced this pull request Nov 1, 2022
bparees added a commit to bparees/origin that referenced this pull request Nov 1, 2022
@soltysh soltysh deleted the rebase-1.25.0 branch November 8, 2022 12:46
tjungblu pushed a commit to tjungblu/origin that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants