Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Oct 24, 2022

Reverts #27416 ; tracked by TRT-635

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Since this merged, CI payloads have been failing on 4.11 -> 4.12 upgrades, exceeding time outs and reaching 4+ hours for some runs. It's not hitting every run, but it is hitting most. There was only one minor ovn aws upgrade on that PR, which unfortunately succeeded, but the aggregated ones failed due to timeouts.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of /payload 4.12 ci blocking. The /payload commands on the originlal PR timed out after 3h, we may need to investigate the timeout configured for those.

CC: @soltysh

@openshift-ci openshift-ci bot requested review from awgreene and bparees October 24, 2022 11:48
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels Oct 24, 2022
@stbenjam
Copy link
Member Author

/label approved
/skip
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-image-registry
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-gcp-builds
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-image-ecosystem
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-agnostic-ovn-cmd, ci/prow/e2e-aws-csi, ci/prow/e2e-aws-image-registry, ci/prow/e2e-aws-ovn-cgroupsv2, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-aws-ovn-single-node-serial, ci/prow/e2e-aws-ovn-single-node-upgrade, ci/prow/e2e-gcp-builds, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-image-ecosystem, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-rt-upgrade, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-metal-ipi-sdn, ci/prow/e2e-openstack-ovn

Details

In response to this:

/label approved
/skip
/override ci/prow/e2e-agnostic-ovn-cmd
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-image-registry
/override ci/prow/e2e-aws-ovn-cgroupsv2
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-single-node-serial
/override ci/prow/e2e-aws-ovn-single-node-upgrade
/override ci/prow/e2e-gcp-builds
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-image-ecosystem
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-rt-upgrade
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-sdn
/override ci/prow/e2e-openstack-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval by writing /assign @soltysh in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@stbenjam
Copy link
Member Author

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit a86fa52 into openshift:master Oct 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam stbenjam deleted the revert-27416-rebase-1.25.0 branch October 24, 2022 13:12
@soltysh soltysh mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants