Drop template.openshift.io apigroup dependency #27476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Member
|
/uncc |
ingvagabund
force-pushed
the
drop-template-apigroup-dep
branch
3 times, most recently
from
8fb3706 to
edb3b6e
Compare
ingvagabund
changed the title
ingvagabund
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ingvagabund
force-pushed
the
drop-template-apigroup-dep
branch
3 times, most recently
from
40b7c80 to
8ff24b6
Compare
ingvagabund
commented
Oct 21, 2022
ingvagabund
commented
Oct 21, 2022
| if err != nil { | ||
| return "", err | ||
| func DeployNewRouterShard(oc *exutil.CLI, timeout time.Duration, cfg Config) (*operatorv1.IngressController, error) { | ||
| ingressCtrl := &operatorv1.IngressController{ |
Member
Author
There was a problem hiding this comment.
This is actually another dependency on operator.openshift.io api group which has not been taken into account.
@pmtk @dhellmann based on https://coreos.slack.com/archives/C03DP9PABNC/p1666186991705809 discussion this should be acceptable given there's no cluster-wide proxy available in MicroShift by default.
ingvagabund
force-pushed
the
drop-template-apigroup-dep
branch
from
8ff24b6 to
a5d56ef
Compare
Member
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
ingvagabund
force-pushed
the
drop-template-apigroup-dep
branch
from
a5d56ef to
14703d9
Compare
openshift-merge-robot
removed
the
needs-rebase
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
/retest-required |
Member
Author
|
/test all |
Member
Author
|
/retest-required |
The templating can be replaced by explicitly creating a pod
ingvagabund
force-pushed
the
drop-template-apigroup-dep
branch
from
c334f2d to
b55caa5
Compare
openshift-merge-robot
removed
the
needs-rebase
soltysh
added
the
tide/merge-method-squash
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, Miciah, pmtk, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
/retest-required |
2 similar comments
Member
Author
|
/retest-required |
Member
Author
|
/retest-required |
Contributor
|
@ingvagabund: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
tjungblu
pushed a commit
to tjungblu/origin
that referenced
this pull request
Apr 11, 2023
* Drop template from testdata/router/router-common.yaml * Drop testdata/router/router-scoped.yaml The templating can be replaced by explicitly creating a pod * Drop testdata/router/router-override.yaml * Drop testdata/router/router-override-domains.yaml * Drop testdata/router/router-grpc-interop.yaml * Drop testdata/router/router-grpc-interop-routes.yaml * Drop testdata/router/router-h2spec.yaml * Drop testdata/router/router-h2spec-routes.yaml * Drop testdata/router/router-http2.yaml * Drop testdata/router/router-http2-routes.yaml * Drop testdata/router/router-idle.yaml * Drop testdata/router/router-config-manager.yaml * Drop testdata/router/weighted-router.yaml * Remove HAProxy template.openshift.io from test/extended/util/annotate/rules.go * Drop testdata/router/router-shard.yaml template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency of the router tests on the template.openshift.io api group.