OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency #27546

ingvagabund · 2022-11-14T11:54:21Z

Backporting #27476 into 4.12

The templating can be replaced by explicitly creating a pod

…/rules.go

openshift-ci · 2022-11-14T11:54:25Z

@ingvagabund: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.12] Drop template.openshift.io apigroup dependency

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve

openshift-ci · 2022-11-14T12:25:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ingvagabund · 2022-11-14T14:02:22Z

/retest-required

ingvagabund · 2022-11-14T14:38:17Z

/retest-required

ingvagabund · 2022-11-15T08:59:22Z

/retest-required

ingvagabund · 2022-11-15T11:27:43Z

/retest-required

openshift-ci · 2022-11-15T13:16:35Z

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	`7b97fc4`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-ovn-single-node-serial	`7b97fc4`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-agnostic-ovn-cmd	`7b97fc4`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-aws-ovn-single-node-upgrade	`7b97fc4`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-aws-ovn-upgrade	`7b97fc4`	link	false	`/test e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ingvagabund · 2022-11-15T13:24:36Z

/retest-required

openshift-ci · 2022-11-15T15:41:59Z

@ingvagabund: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-15T15:42:00Z

@ingvagabund: This pull request references Jira Issue OCPBUGS-3694, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12.z" instead
expected Jira Issue OCPBUGS-3694 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backporting #27476 into 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund · 2022-11-15T15:42:38Z

/jira refresh

openshift-ci-robot · 2022-11-15T15:42:40Z

@ingvagabund: This pull request references Jira Issue OCPBUGS-3694, which is invalid:

expected Jira Issue OCPBUGS-3694 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund · 2022-11-15T15:43:04Z

/jira refresh

openshift-ci-robot · 2022-11-15T15:43:11Z

@ingvagabund: This pull request references Jira Issue OCPBUGS-3694, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-3693 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-3693 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund · 2022-11-15T17:05:07Z

/retest-required

openshift-ci-robot · 2022-11-15T19:40:48Z

@ingvagabund: All pull requests linked via external trackers have merged:

openshift/origin#27546

Jira Issue OCPBUGS-3694 has been moved to the MODIFIED state.

Details

In response to this:

Backporting #27476 into 4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ingvagabund added 15 commits November 14, 2022 12:52

Drop template from testdata/router/router-common.yaml

55345dc

Drop testdata/router/router-scoped.yaml

b021efc

The templating can be replaced by explicitly creating a pod

Drop testdata/router/router-override.yaml

49530f5

Drop testdata/router/router-override-domains.yaml

cb31d9f

Drop testdata/router/router-grpc-interop.yaml

ff33450

Drop testdata/router/router-grpc-interop-routes.yaml

11dc342

Drop testdata/router/router-h2spec.yaml

82fc840

Drop testdata/router/router-h2spec-routes.yaml

561cd8a

Drop testdata/router/router-http2.yaml

280feaa

Drop testdata/router/router-http2-routes.yaml

00d7dd6

Drop testdata/router/router-idle.yaml

b5acd0b

Drop testdata/router/router-config-manager.yaml

d6548da

Drop testdata/router/weighted-router.yaml

0b05573

Remove HAProxy template.openshift.io from test/extended/util/annotate…

3042d47

…/rules.go

Drop testdata/router/router-shard.yaml template

7b97fc4

openshift-ci bot requested review from bparees and frobware November 14, 2022 11:55

soltysh added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 14, 2022

soltysh approved these changes Nov 14, 2022

View reviewed changes

openshift-ci bot assigned soltysh Nov 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022

ingvagabund changed the title ~~[4.12] Drop template.openshift.io apigroup dependency~~ OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency Nov 15, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 15, 2022

openshift-ci bot requested a review from lihongan November 15, 2022 15:43

openshift-merge-robot merged commit cf04d3c into openshift:release-4.12 Nov 15, 2022

ingvagabund deleted the drop-template-apigroup-dep-4.12 branch November 16, 2022 10:57

dgoodwin mentioned this pull request Feb 28, 2023

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry #27758

Closed

OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency #27546

OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency #27546

Uh oh!

Conversation

ingvagabund commented Nov 14, 2022

Uh oh!

openshift-ci bot commented Nov 14, 2022

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 14, 2022

Uh oh!

ingvagabund commented Nov 14, 2022

Uh oh!

ingvagabund commented Nov 14, 2022

Uh oh!

ingvagabund commented Nov 15, 2022

Uh oh!

ingvagabund commented Nov 15, 2022

Uh oh!

openshift-ci bot commented Nov 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ingvagabund commented Nov 15, 2022

Uh oh!

openshift-ci bot commented Nov 15, 2022

Uh oh!

openshift-ci-robot commented Nov 15, 2022

Uh oh!

ingvagabund commented Nov 15, 2022

Uh oh!

openshift-ci-robot commented Nov 15, 2022

Uh oh!

ingvagabund commented Nov 15, 2022

Uh oh!

openshift-ci-robot commented Nov 15, 2022

Uh oh!

ingvagabund commented Nov 15, 2022

Uh oh!

openshift-ci-robot commented Nov 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci bot commented Nov 15, 2022 •

edited

Loading