Skip to content

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Feb 28, 2023

These three commits were part of #27636 and #27651 which fixed a problem where we stopped collecting disruption data for these two backends in CI testing. Unfortunately the fix was not backported to 4.12 when we discovered it. This corrects that.

TRT-825

Discovered that we are getting no data for image registry since Dec 7th
due to PR openshift#27574 which shut off the entire monitor if we have less than
the required 100 runs to appear in the file of allowances to enforce. I
guess at this time, we did not have enough runs with image registry for
4.13. (which is unusual)

Skip the test, but let the monitor run.
Previous attempt did not work, as we were still bypassing
FrameworkEventIntervals() which is needed to add the test summary, which
eventually results in the AdditionalEvents json files in artifacts,
which are then merged into the overall events and disruption data files.
Without calling it, we still get no disruption data uploaded.

Move the nil check into the ExpectNoDisruption function, and allow
FrameworkEventIntervals to run as it should.
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the base branch from master to release-4.12 February 28, 2023 12:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

backport disrupt gathering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title backport disrupt gathering OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@openshift-ci-robot
Copy link

@dgoodwin: No Jira issue with key OCPBUGS-8025 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

  • Switch imports to ginkgo v2
  • Switch to go-ldap/v3
  • Add newlines to SimultaneousPodIPController
  • Adapt to v2 by migrating use of extensions/table package
  • Adapt to v2 by migrating use of config.GinkgoConfig to ginkgo.GinkgoConfiguration()
  • Adopt to v2 by migrating from CurrentGinkgoTestDescription() to CurrentSpecReport()
  • Remove dead code - ExecuteTest
  • Remove dead code - setTestExclusion
  • Use rhel-8-release-golang-1.19-openshift-4.12 builder
  • Update dependencies
  • React to k8s 1.25 changes
  • Update ETCD storage test alpha versions
  • Update test images
  • Add registry.k8s.io/pause:3.8
  • ginkgo v2 adaptation
  • Drop [Suite:openshift/registry/serial] from Image signature worklow tests
  • Update gofmt with golang 1.19
  • Fix TestBackendSampler_checkConnection unit test
  • make update
  • Switch from waiting for running pod to wait for a completed pod in image tests
  • Do not panic when test annotation is not found
  • Only invoke BuildTree one time
  • Update ginkgo dependency
  • Skip broken [sig-devex][Feature:ImageEcosystem] tests
  • Revert "Merge pull request Merge upgrade and conformance alert backstop tests #27533 from dgoodwin/merge-alert-backstops"
  • OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency (OCPBUGS-3694: [4.12] Drop template.openshift.io apigroup dependency #27546)
  • Fix flake reporting for certain tests.
  • Bump kubernetes to latest release-4.12
  • Unskip service session affinity tests
  • Nginx 1.18 images will reach EOL in November 2022
  • Skip disruption test if no historical data
  • Add Kuryr exception to "pods should successfully create sandboxes" test
  • update git repo paths to match must-gather and inspect
  • add user in log for each resourcewatch modification
  • add yaml suffix for resource watch
  • handle managers keys that are for subresources
  • simplify the resource watch controller down to the active components
  • avoid unintended updates for resourcewatch git repo
  • shell out to git for resource-watch
  • remove unncessary vendoring
  • Use cluster network MTU for bond interfaces
  • upgrade/adminack: guarantee one admin ack check post-upgrade
  • upgrade/adminack: optimize the post-upgrade check
  • Fix intervalcreation incorrect year unit test bug
  • upgrade/adminack: simplify polling and unblock "guaranteed" post-upgrade check
  • upgrade/adminack: wait up to 4m until gate propagates to upgradeable
  • extended: security: do not explicitly set api audience on token request
  • OCPBUGS-1125: remove reference to old guard pods
  • Fix missing disruption uploads.
  • Fix missing disruption data again.
  • Add logging for the job type we determined

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bparees and soltysh February 28, 2023 12:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2023

@dgoodwin: No Jira issue with key OCPBUGS-8025 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

These three commits were part of #27636 and #27651 which fixed a problem where we stopped collecting disruption data for these two backends in CI testing. Unfortunately the fix was not backported to 4.12 when we discovered it. This corrects that.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dgoodwin: No Jira issue with key OCPBUGS-8025 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

These three commits were part of #27636 and #27651 which fixed a problem where we stopped collecting disruption data for these two backends in CI testing. Unfortunately the fix was not backported to 4.12 when we discovered it. This corrects that.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry Bug OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title Bug OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry [release-4.12] OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@dgoodwin
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title [release-4.12] OCPBUGS-8025: Backport fixes to resume gathering CI disruption data for SLB and image registry [release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2023
@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-8024, which is invalid:

  • expected the bug to target the "4.12.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-8024 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

These three commits were part of #27636 and #27651 which fixed a problem where we stopped collecting disruption data for these two backends in CI testing. Unfortunately the fix was not backported to 4.12 when we discovered it. This corrects that.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 28, 2023
@dgoodwin
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title [release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin dgoodwin changed the title OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry [release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-8024: Backport fixes to resume gathering CI disruption data for SLB and image registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

/close

@openshift-ci openshift-ci bot closed this Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dgoodwin: This pull request references Jira Issue OCPBUGS-8024. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

These three commits were part of #27636 and #27651 which fixed a problem where we stopped collecting disruption data for these two backends in CI testing. Unfortunately the fix was not backported to 4.12 when we discovered it. This corrects that.

TRT-825

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node ccca62d link false /test e2e-aws-ovn-single-node
ci/prow/unit ccca62d link true /test unit
ci/prow/e2e-agnostic-ovn-cmd ccca62d link false /test e2e-agnostic-ovn-cmd
ci/prow/lint ccca62d link true /test lint
ci/prow/e2e-gcp-ovn-etcd-scaling ccca62d link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/verify-deps ccca62d link true /test verify-deps
ci/prow/e2e-aws-ovn-cgroupsv2 ccca62d link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-csi ccca62d link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-fips ccca62d link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-single-node-serial ccca62d link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-openstack-ovn ccca62d link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-csi ccca62d link false /test e2e-gcp-csi
ci/prow/e2e-metal-ipi-sdn ccca62d link false /test e2e-metal-ipi-sdn
ci/prow/e2e-gcp-ovn-builds ccca62d link true /test e2e-gcp-ovn-builds
ci/prow/e2e-vsphere-ovn-etcd-scaling ccca62d link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn ccca62d link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 ccca62d link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-upgrade ccca62d link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-serial ccca62d link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn-rt-upgrade ccca62d link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/verify ccca62d link true /test verify
ci/prow/e2e-aws-ovn-upgrade ccca62d link false /test e2e-aws-ovn-upgrade
ci/prow/images ccca62d link true /test images
ci/prow/e2e-aws-ovn-etcd-scaling ccca62d link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-upgrade ccca62d link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-azure-ovn-etcd-scaling ccca62d link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants