Skip to content

OCPBUGS-3633: Revert "Merge pull request #27547 from dgoodwin/revert-alert-test-merger" #27555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dgoodwin wants to merge 1 commit into from
Closed

OCPBUGS-3633: Revert "Merge pull request #27547 from dgoodwin/revert-alert-test-merger" #27555

dgoodwin wants to merge 1 commit into from

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Nov 16, 2022 •
edited
Loading

This reverts commit 10442fb, reversing
changes made to ceb552b.

We likely reverted the wrong PR when we pulled this out. THe flakes disappeared on Nov 4th, 6 days before this PR went in. It was likely safe. Just bad luck the missing flakes most common showed up on the tests being refactored here.

@dgoodwin
Revert "Merge pull request openshift#27547 from dgoodwin/revert-alert…
e1277fd 
…-test-merger"

This reverts commit 10442fb, reversing
changes made to ceb552b.
@openshift-ci openshift-ci bot requested review from jan--f and jwforres November 16, 2022 13:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@dgoodwin dgoodwin changed the title Revert "Merge pull request #27547 from dgoodwin/revert-alert-test-merger" OCPBUGS-3633: Revert "Merge pull request #27547 from dgoodwin/revert-alert-test-merger" Nov 16, 2022
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 16, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 16, 2022

@dgoodwin: This pull request references Jira Issue OCPBUGS-3633, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit 10442fb, reversing
changes made to ceb552b.

We likely reverted the wrong PR when we pulled this out. THe flakes disappeared on Nov 4th, 6 days before this PR went in. It was likely safe. Just bad luck the missing flakes most common showed up on the tests being refactored here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor Author

dgoodwin commented Nov 16, 2022

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 16, 2022

@dgoodwin: This pull request references Jira Issue OCPBUGS-3633, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn e1277fd link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn e1277fd link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade e1277fd link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node e1277fd link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-csi e1277fd link false /test e2e-gcp-csi
ci/prow/e2e-agnostic-ovn-cmd e1277fd link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial e1277fd link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-serial e1277fd link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-single-node-upgrade e1277fd link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 17, 2022
Merged
@dgoodwin
Copy link
Contributor Author

dgoodwin commented Nov 17, 2022

/close

Replaced by #27559

@openshift-ci openshift-ci bot closed this Nov 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2022

@dgoodwin: Closed this PR.

Details

In response to this:

/close

Replaced by #27559

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2022

@dgoodwin: This pull request references Jira Issue OCPBUGS-3633. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit 10442fb, reversing
changes made to ceb552b.

We likely reverted the wrong PR when we pulled this out. THe flakes disappeared on Nov 4th, 6 days before this PR went in. It was likely safe. Just bad luck the missing flakes most common showed up on the tests being refactored here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@jwforres jwforres Awaiting requested review from jwforres

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgoodwin @openshift-ci-robot