Skip to content

test/extended/prometheus: fix test with enabled telemetry#27915

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
simonpasquier:fix-telemetry-disabled-skip
May 24, 2023
Merged

test/extended/prometheus: fix test with enabled telemetry#27915
openshift-merge-robot merged 1 commit into
openshift:masterfrom
simonpasquier:fix-telemetry-disabled-skip

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

@simonpasquier simonpasquier commented May 10, 2023

Telemetry tests were always skipped because nothing checked the first value returned by telemetryIsEnabled().

For example, the openshift/telemeter e2e-aws-ovn job skips the tests while it's enabled in openshift/release.

ping @wking since you submitted #27422.

@simonpasquier
test/extended/prometheus: fix test with enabled telemetry
b8a285e 
Telemetry tests were always skipped because nothing checked the first
value returned by telemetryIsEnabled().

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier simonpasquier mentioned this pull request May 10, 2023
Merged
4 tasks
@openshift-ci openshift-ci Bot requested review from jan--f and mfojtik May 10, 2023 14:37
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 15, 2023

/retest-required

@jan--f
Copy link
Copy Markdown
Contributor

jan--f commented May 15, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 15, 2023

/retest-required

Remaining retests: 0 against base HEAD 2d41e52 and 2 for PR HEAD b8a285e in total

@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 16, 2023

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 16, 2023

/retest-required

Remaining retests: 0 against base HEAD 81c9056 and 1 for PR HEAD b8a285e in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 17, 2023

/retest-required

Remaining retests: 0 against base HEAD 221e522 and 0 for PR HEAD b8a285e in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 17, 2023

/hold

Revision b8a285e was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2023
@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 22, 2023

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2023 •
edited
Loading

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial b8a285e link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd b8a285e link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-upgrade b8a285e link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-etcd-scaling b8a285e link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling b8a285e link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-upgrade b8a285e link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-openstack-ovn b8a285e link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-cgroupsv2 b8a285e link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-vsphere-ovn-etcd-scaling b8a285e link false /test e2e-vsphere-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 23, 2023

/test e2e-aws-ovn-serial

@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 23, 2023

/skip

@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 24, 2023

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6735e5f into openshift:master May 24, 2023
@neisw neisw mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@jan--f jan--f

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonpasquier @jan--f @openshift-ci-robot @openshift-merge-robot