Skip to content

Revert "test/extended/prometheus: fix test with enabled telemetry"#27957

Closed
neisw wants to merge 1 commit into
openshift:masterfrom
neisw:revert-27915-fix-telemetry-disabled-skip
Closed

Revert "test/extended/prometheus: fix test with enabled telemetry"#27957
neisw wants to merge 1 commit into
openshift:masterfrom
neisw:revert-27915-fix-telemetry-disabled-skip

Conversation

@neisw
Copy link
Copy Markdown
Contributor

@neisw neisw commented May 31, 2023

Reverts #27915

Per TRT policy, we are reverting this breaking change to get ci and/or nightly payloads flowing again.

To unrevert this revert, revert this PR, and layer an additional separate commit on top that addresses the problem.

Before merging the unrevert, please run these jobs on the PR and check the result of periodic-ci-openshift-release-master-nightly-4.14-e2e-vsphere-ovn-techpreview-serial to confirm the fix has corrected the problem.

@openshift-ci openshift-ci Bot requested review from jan--f and simonpasquier May 31, 2023 12:40
@simonpasquier
Copy link
Copy Markdown
Contributor

/lgtm

I'll follow-up with the unrevert PR.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@neisw
Copy link
Copy Markdown
Contributor Author

neisw commented May 31, 2023

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2023

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial 84c5974 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-serial 84c5974 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 84c5974 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link
Copy Markdown

Job Failure Risk Analysis for sha: 84c5974

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2023
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Copy Markdown
Member

stbenjam commented Jun 2, 2023

Superseded by #27959

/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2023

@stbenjam: Closed this PR.

Details

In response to this:

Superseded by #27959

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Jun 2, 2023
@neisw
Copy link
Copy Markdown
Contributor Author

neisw commented Jun 6, 2023

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants