Skip to content

OCPBUGS-14338: test/extended/prometheus: increase telemetry series threshold#27959

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
simonpasquier:OCPBUGS-14338
Jun 1, 2023
Merged

OCPBUGS-14338: test/extended/prometheus: increase telemetry series threshold#27959
openshift-merge-robot merged 1 commit into
openshift:masterfrom
simonpasquier:OCPBUGS-14338

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

@simonpasquier simonpasquier commented May 31, 2023

TechPreview jobs happen to increase significantly the number of series being sent to telemetry (especially because of the additional CRDs being installed which increase the cardinality of the
cluster:usage:resources:sum metric).

@openshift-ci openshift-ci Bot requested review from jan--f and soltysh May 31, 2023 15:40
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@simonpasquier simonpasquier changed the title test/extended/prometheus: increase telemetry series threshold OCPBUGS-14338: test/extended/prometheus: increase telemetry series threshold May 31, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 31, 2023

@simonpasquier: This pull request references Jira Issue OCPBUGS-14338, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

TechPreview jobs happen to increase significantly the number of series being sent to telemetry (especially because of the additional CRDs being installed which increase the cardinality of the
cluster:usage:resources:sum metric).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 31, 2023
@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented May 31, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 31, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 31, 2023

@simonpasquier: This pull request references Jira Issue OCPBUGS-14338, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from juzhao May 31, 2023 15:59
@jan--f
Copy link
Copy Markdown
Contributor

jan--f commented May 31, 2023

A make update run should fix the verify job. Otherwise this lgtm.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2023
@simonpasquier
test/extended/prometheus: increase telemetry series threshold
30941b6 
TechPreview jobs happen to increase significantly the number of series
being sent to telemetry (especially because of the additional CRDs being
installed which increase the cardinality of the
`cluster:usage:resources:sum` metric).

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2023
@simonpasquier
Copy link
Copy Markdown
Contributor Author

simonpasquier commented Jun 1, 2023

PR rebased to resolve conflicts + generated code updated.

@machine424
Copy link
Copy Markdown
Contributor

machine424 commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6629b0d into openshift:master Jun 1, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 1, 2023

@simonpasquier: Jira Issue OCPBUGS-14338: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14338 has been moved to the MODIFIED state.

Details

In response to this:

TechPreview jobs happen to increase significantly the number of series being sent to telemetry (especially because of the additional CRDs being installed which increase the cardinality of the
cluster:usage:resources:sum metric).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2023

@simonpasquier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 30941b6 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node 30941b6 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-agnostic-ovn-cmd 30941b6 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-openstack-ovn 30941b6 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 30941b6 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam stbenjam mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@soltysh soltysh Awaiting requested review from soltysh

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@machine424 machine424

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@simonpasquier @openshift-ci-robot @jan--f @machine424 @openshift-merge-robot