Skip to content

NO-JIRA: enforce termination policy#28777

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
deads2k:enforce
May 9, 2024
Merged

NO-JIRA: enforce termination policy#28777
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
deads2k:enforce

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented May 7, 2024

We're down to a few violations (first couple hundred fixed). This updates the test to prevent new ones from being added.

deads2k
deads2k commented May 7, 2024
View reviewed changes
Comment thread pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
Comment on lines +124 to +136
"openshift-cluster-csi-drivers": sets.NewString(
"containers[openstack-cinder-csi-driver-operator]",
"containers[azure-file-csi-driver-operator]",
"containers[shared-resource-csi-driver-operator]",
"containers[vmware-vsphere-csi-driver-operator]",
"containers[vsphere-webhook]",
"pods/kubevirt-csi-node",
"pods/nutanix-csi-controller",
"pods/nutanix-csi-node",
"pods/ibm-vpc-block-csi-controller",
"pods/ibm-vpc-block-csi-node",
"pods/powervs-block-csi-driver-operator",
),
Copy link
Copy Markdown
Contributor Author

@deads2k deads2k May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy list produced from https://search.dptools.openshift.org/?search=must+have+terminationMessagePolicy%3D&maxAge=48h&context=1&type=junit&name=4.16.*&excludeName=upgrade&maxMatches=5&maxBytes=20971520&groupBy=job

@jsafrane

Copy link
Copy Markdown
Member

@dobsonj dobsonj May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this covers all of them except for kubevirt and nutanix:
openshift/cluster-storage-operator#470
openshift/vmware-vsphere-csi-driver-operator#231
openshift/ibm-vpc-block-csi-driver-operator#114

deads2k
deads2k commented May 7, 2024
View reviewed changes
Comment thread pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
Comment on lines +120 to +123
"openshift-cluster-api": sets.NewString(
"pods/capa-controller-manager",
"pods/capi-controller-manager",
),
Copy link
Copy Markdown
Contributor Author

@deads2k deads2k May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelSpeed

deads2k
deads2k commented May 7, 2024
View reviewed changes
Comment thread pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
Comment on lines +140 to +141
"openshift-machine-api": sets.NewString(
"containers[machine-ipam-controller]",
Copy link
Copy Markdown
Contributor Author

@deads2k deads2k May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelSpeed

Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirect to @rvanderp3 , PTAL at https://github.com/openshift-splat-team/machine-ipam-controller/pull/7 for the fix

deads2k
deads2k commented May 7, 2024
View reviewed changes
Comment thread pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
Comment on lines +137 to +138
"openshift-cloud-controller-manager": sets.NewString(
"pods/aws-cloud-controller-manager",
Copy link
Copy Markdown
Contributor Author

@deads2k deads2k May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelSpeed ?

@openshift-ci openshift-ci Bot requested review from sjenning and soltysh May 7, 2024 18:22
deads2k
deads2k commented May 7, 2024
View reviewed changes
Comment thread pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
Comment on lines +143 to +144
"openshift-multus": sets.NewString(
"containers[multus-networkpolicy]",
Copy link
Copy Markdown
Contributor Author

@deads2k deads2k May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trozet looks like networking

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
deads2k
deads2k commented May 7, 2024
View reviewed changes
Comment thread pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go
Comment on lines +117 to +118
"openshift-catalogd": sets.NewString(
"pods/catalogd-controller-manager",
Copy link
Copy Markdown
Contributor Author

@deads2k deads2k May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelanford I think you're waiting on a tag for these.

@deads2k deads2k changed the title enforce termination policy NO-JIRA: enforce termination policy May 7, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 7, 2024

@deads2k: This pull request explicitly references no jira issue.

Details

In response to this:

We're down to a few violations (first couple hundred fixed). This updates the test to prevent new ones from being added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2024
@neisw
Copy link
Copy Markdown
Contributor

neisw commented May 8, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 8, 2024

/test all

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 8, 2024

/retest-required

Remaining retests: 0 against base HEAD 9d46920 and 2 for PR HEAD fd5a103 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 9, 2024

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade fd5a103 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 06199cd into openshift:master May 9, 2024
@dobsonj dobsonj mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@sjenning sjenning Awaiting requested review from sjenning

@soltysh soltysh Awaiting requested review from soltysh

+1 more reviewer

@dobsonj dobsonj dobsonj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@neisw neisw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deads2k @openshift-ci-robot @neisw @dobsonj @JoelSpeed