Skip to content

NO-JIRA: drop ocp-storage exceptions for termination policy#28793

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
dobsonj:storage-termination-policy-exceptions
Aug 8, 2024
Merged

NO-JIRA: drop ocp-storage exceptions for termination policy#28793
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
dobsonj:storage-termination-policy-exceptions

Conversation

@dobsonj
Copy link
Copy Markdown
Member

@dobsonj dobsonj commented May 9, 2024

Follow up to #28777

This drops the exceptions that should be fixed by:

openshift/cluster-storage-operator#470
openshift/vmware-vsphere-csi-driver-operator#231
openshift/ibm-vpc-block-csi-driver-operator#114

I'm hoping the presubmit jobs will tell us that they really are fixed.

/cc @deads2k @jsafrane
/test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci openshift-ci Bot requested review from deads2k and jsafrane May 9, 2024 21:26
@openshift-ci-robot
Copy link
Copy Markdown

@dobsonj: This pull request explicitly references no jira issue.

Details

In response to this:

Follow up to #28777

This drops the exceptions that should be fixed by:

openshift/cluster-storage-operator#470
openshift/vmware-vsphere-csi-driver-operator#231
openshift/ibm-vpc-block-csi-driver-operator#114

I'm hoping the presubmit jobs will tell us that they really are fixed.

/cc @deads2k @jsafrane
/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@dobsonj dobsonj force-pushed the storage-termination-policy-exceptions branch from da7a899 to 85b1fdd Compare August 6, 2024 19:48
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Aug 7, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@dobsonj
Copy link
Copy Markdown
Member Author

dobsonj commented Aug 7, 2024

/retest-required

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Aug 7, 2024

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@dobsonj
Copy link
Copy Markdown
Member Author

dobsonj commented Aug 7, 2024

/test e2e-aws-ovn-edge-zones

1 similar comment
@dobsonj
Copy link
Copy Markdown
Member Author

dobsonj commented Aug 7, 2024

/test e2e-aws-ovn-edge-zones

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 56c3413 and 2 for PR HEAD 85b1fdd in total

@dobsonj
Copy link
Copy Markdown
Member Author

dobsonj commented Aug 8, 2024

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn da7a899 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 85b1fdd link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 85b1fdd link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-ipsec-serial 85b1fdd link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link
Copy Markdown

Job Failure Risk Analysis for sha: 85b1fdd

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones IncompleteTests
Tests for this run (101) are below the historical average (1582): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Medium
[sig-network] pods should successfully create sandboxes by adding pod to network
This test has passed 95.26% of 2005 runs on release 4.18 [Overall] in the last week.

Open Bugs
s390x: [sig-network] pods should successfully create sandboxes by adding pod to network fails with error adding pod to CNI network

@dobsonj
Copy link
Copy Markdown
Member Author

dobsonj commented Aug 8, 2024

/test e2e-aws-ovn-edge-zones

@openshift-merge-bot openshift-merge-bot Bot merged commit d76b75c into openshift:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants