MULTIARCH-5391: Add new featuregate test to check if desired.Architecture is set as intended#29808
Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom Jun 10, 2025
Conversation
Contributor
Author
|
/test e2e-gcp-ovn-techpreview-serial |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 9d53ca0
New tests seen in this PR at sha: 9d53ca0
|
wking
reviewed
May 27, 2025
| @@ -0,0 +1,5 @@ | |||
| reviewers: | |||
| - cluster-version-operator-test-case-reviewers | |||
Member
There was a problem hiding this comment.
Our existing consumer for this alias is in test/extended/util/openshift/clusterversionoperator. I'm not all that clear on how test/extended is organized, but it seems like we should keep these CVO-functionality tests collected in the same directory?
Contributor
Author
There was a problem hiding this comment.
wking
reviewed
May 27, 2025
wking
reviewed
May 27, 2025
Prashanth684
force-pushed
the
4552-cvo-test
branch
from
9d53ca0 to
bca8bc2
Compare
Contributor
Author
|
/retest-required |
Member
|
/cc |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview-serial |
Contributor
|
@Prashanth684: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/test e2e-gcp-ovn-techpreview |
|
Job Failure Risk Analysis for sha: bca8bc2
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: bca8bc2
New tests seen in this PR at sha: bca8bc2
|
Prashanth684
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@Prashanth684: This pull request references MULTIARCH-5391 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dgoodwin
reviewed
Jun 9, 2025
…ntended A new featuregated field was introduced a while ago under clusterversion status - `desired.Architecture` which denotes the architecture of the release image being reconciled to. As we plan to promote the feature gate to default - this adds a basic test to check if the `desired.Architecture` is set based on the `release.openshift.io/architecture: multi` being present as part of the release metadata. This field in the ClusterVersion was added as part of https://issues.redhat.com/browse/MULTIARCH-4552 and is under the ImageStreamImportMode feature gate.
Prashanth684
force-pushed
the
4552-cvo-test
branch
from
bca8bc2 to
764dbfd
Compare
Contributor
Author
|
/test e2e-gcp-ovn-techpreview |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
/retest-required |
|
Job Failure Risk Analysis for sha: 764dbfd
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 764dbfd
New tests seen in this PR at sha: 764dbfd
|
Contributor
Author
|
/override ci/prow/e2e-vsphere-ovn-upi |
Contributor
|
@Prashanth684: Overrode contexts on behalf of Prashanth684: ci/prow/e2e-vsphere-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
@Prashanth684: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 757cf53
into
openshift:main
40 of 60 checks passed
Contributor
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
openshift-merge-bot Bot
added a commit
that referenced
this pull request
Jun 27, 2025
OCPBUGS-57632: Revert "Merge pull request #29808 from Prashanth684/4552-cvo-test"
Prashanth684
added a commit
to Prashanth684/origin
that referenced
this pull request
Jul 8, 2025
…o-test" This reverts commit 5018491.
openshift-merge-bot Bot
added a commit
that referenced
this pull request
Jul 18, 2025
MULTIARCH-5390: Reapply "Merge pull request #29808 from Prashanth684/4552-cvo-test"
ShudiLi
pushed a commit
to ShudiLi/origin
that referenced
this pull request
Dec 11, 2025
…o-test" This reverts commit 5018491.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new featuregated field was introduced a while ago under clusterversion status -
desired.Architecturewhich denotes the architecture of the release image being reconciled to. As we plan to promote the feature gate to default - this adds a basic test to check if thedesired.Architectureis set based on therelease.openshift.io/architecture: multibeing present as part of the release metadata.