RFC: refactor persistent storage example and add Cinder documentation#4403
RFC: refactor persistent storage example and add Cinder documentation#4403openshift-bot merged 3 commits intoopenshift:masterfrom
Conversation
jsafrane
force-pushed
the
devel/cinder-doc
branch
from
c3a9f65 to
9384957
Compare
|
At first glance, this looks like a great addition to the wordpress example that shows how to change out the PV part in the backend. I'll take a more careful/thorough look later. |
|
Note that I had to disable SELinux to make it working - newly created ext3 filesystems are not labelled (system_u:object_r:unlabeled_t) and SELinux denies containers (svirt_lxc_net_t) to write to them. This is not Cinder related, it provides block device, not the filesystem. All other block-device-like volumes (iSCSI, RBD, ...) will have the same problem. Is the user supposed to label the filesystems inside the volumes? |
|
@markturansky @childsb Review please. |
|
LGTM |
jsafrane
force-pushed
the
devel/cinder-doc
branch
from
9384957 to
562fcd0
Compare
|
Rebased. Also, Kubernetes PR for OpenStack/Cinder was merged and it will land in OpenShift with next Kubernetes rebase. |
Move the NFS docs to standalone document and leave the common parts to be reused by documentation of other volume plugins.
jsafrane
force-pushed
the
devel/cinder-doc
branch
from
562fcd0 to
a142dbc
Compare
Signed-off-by: Huamin Chen <hchen@redhat.com>
jsafrane
force-pushed
the
devel/cinder-doc
branch
from
059e9db to
a81be3f
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5856/) (Image: devenv-fedora_2480) |
|
Evaluated for origin merge up to a81be3f |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5856/) |
|
Evaluated for origin test up to a81be3f |
Merged by openshift-bot
6 participants
These two patches modify the Wordpress example to include documentation of Cinder persistent volumes. Additional storage plugins can be added easily later. Is this something that you would be interested in? Is the structure fine?
Cinder support is heading to upstream Kubernetes in [PR #6689] kubernetes/kubernetes#6689).Kubernetes changes have been merged in openshift/origin commit 2009660