Skip to content

suggest can-i for what-can-i-do#9055

Closed
deads2k wants to merge 2 commits into
openshift:masterfrom
deads2k:cani-suggestions
Closed

suggest can-i for what-can-i-do#9055
deads2k wants to merge 2 commits into
openshift:masterfrom
deads2k:cani-suggestions

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented May 27, 2016

Fixes #9051.

@Kargakis ptal, will open upstream.

@deads2k deads2k force-pushed the cani-suggestions branch from d5a34dd to 8bc96cc Compare May 27, 2016 12:22
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 27, 2016

upstream at spf13/cobra#285

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented May 27, 2016

Can you also rename whatcanido.go to cani.go?

@deads2k deads2k force-pushed the cani-suggestions branch from 8bc96cc to c66e32e Compare May 27, 2016 12:44
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 27, 2016

Can you also rename whatcanido.go to cani.go?

done

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented May 27, 2016 •
edited by deads2k
Loading

LGTM merge

@mfojtik you should be able to rebase without any conflicts on top of this

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented May 27, 2016

removed merge tag. Upstream unit tests discovered that a nested command that has subcommands AND an implementation always fails here.

As a for instance: oc create foo. That should fail because create doesn't take args, but it actually fails because there's no subcommand for it. Must be why they have that check. To my knowledge, there's no flag saying, "this is just a container for other commands", but I'll take a deeper look.

@0xmichalis
Copy link
Copy Markdown
Contributor

0xmichalis commented Jun 2, 2016

@deads2k is this still blocked on upstream work?

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Jun 2, 2016

Yes I think we want spf13/cobra#284 and then maybe one more followup.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 14, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2016
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 29, 2016

Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again

@deads2k deads2k mentioned this pull request Aug 2, 2016
Closed
@deads2k deads2k closed this Aug 2, 2016
@deads2k deads2k deleted the cani-suggestions branch September 6, 2016 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@0xmichalis 0xmichalis

Labels

blocked needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deads2k @0xmichalis @openshift-bot