You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggests were only appearing against the root command, but for nested command structures it makes sense to look for suggestions at the deepest command that was found.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Good unit tests. I want to be able to use suggestions for nested commands, so that rootcommand subcommand misspelled-subsubcommand can get a suggestion. For that to work, I guess I'll need to annotate the Command somehow to indicate that it has no non-flag args.
@juanvallejo want to see what you can do? See the linked pull for usage.
For that to work, I guess I'll need to annotate the Command somehow to indicate that it has no non-flag args.
Sounds related to the PR I just submitted in #284. I also factored out this findSuggestions() function which should make it easier to re-use. Maybe it should be public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggests were only appearing against the root command, but for nested command structures it makes sense to look for suggestions at the deepest command that was found.
@eparis