OCPBUGS-8009: Revert to legacy toolbox by travier · Pull Request #1203 · openshift/os

travier · 2023-03-16T11:08:21Z

Revert "manifest: Back to rhel toolbox"

We now have a legacy toolbox build in the correct repo.

This reverts commit 3c453e5.

manifest/9/2: Get conmon-rs from rhel-9.2-server-ose-4.13 repo

openshift-ci · 2023-03-16T11:08:25Z

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

kola-denylist: re-enable luks.* test on !x86_64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2023-03-16T11:08:38Z

/hold
as we might want to pick up parts of #1202 too

openshift-ci · 2023-03-16T11:10:07Z

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8008: Backports and revert to legacy toolbox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-16T11:10:09Z

@travier: This pull request references Jira Issue OCPBUGS-8008, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.14" instead
expected Jira Issue OCPBUGS-8008 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

kola-denylist: re-enable luks.* test on !x86_64

See #1185

(cherry picked from commit 4c3c5d8)

ci: Disable RHCOS 8 builds & tests

(cherry picked from commit a442b06)

ci: Use RHCOS 9 for builds & tests by default

(cherry picked from commit 100d0d4)

ci: Update fetch path for 9.2 builds

(cherry picked from commit 1c662d7)

ci: Cleanup unused versions and whitespace

(cherry picked from commit 227ca9e)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-16T11:10:22Z

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8009: Backports and revert to legacy toolbox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-16T11:10:23Z

@travier: This pull request references Jira Issue OCPBUGS-8009, which is invalid:

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug RHELBLD-12381 is not in the required OCPBUGS project

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
Use the Jira UI to clone the Jira bug, then in the clone bug:
a. Set the target version to the release you are cherrypicking to.
b. Add an issue link “is blocked by”, which links to the original jira bug
Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

kola-denylist: re-enable luks.* test on !x86_64

See #1185

(cherry picked from commit 4c3c5d8)

ci: Disable RHCOS 8 builds & tests

(cherry picked from commit a442b06)

ci: Use RHCOS 9 for builds & tests by default

(cherry picked from commit 100d0d4)

ci: Update fetch path for 9.2 builds

(cherry picked from commit 1c662d7)

ci: Cleanup unused versions and whitespace

(cherry picked from commit 227ca9e)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2023-03-16T11:17:56Z

/jira refresh

openshift-ci-robot · 2023-03-16T11:17:59Z

@travier: This pull request references Jira Issue OCPBUGS-8009, which is invalid:

expected dependent Jira Issue OCPBUGS-8008 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead
expected dependent Jira Issue OCPBUGS-8008 to target a version in 4.14.0, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuijingHei · 2023-03-16T11:40:21Z

There is #1200 to backport 4c3c5d8, maybe we can close it.

HuijingHei · 2023-03-16T13:11:17Z

/LGTM

HuijingHei · 2023-03-16T13:14:47Z

Just minor question, revert to legacy toolbox is not included in this PR, maybe should remove that in the title.

travier · 2023-03-16T13:15:47Z

See #1203 (comment). It's in #1203 and I'll add to include it here after it lands in 4.14

mike-nguyen · 2023-03-20T14:59:04Z

/label backport-risk-assessed
/label cherry-pick-approved

openshift-ci · 2023-03-29T17:27:41Z

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8009: Revert to legacy toolbox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-29T17:28:02Z

@travier: This pull request references Jira Issue OCPBUGS-8009, which is invalid:

expected dependent Jira Issue OCPBUGS-8008 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Revert "manifest: Back to rhel toolbox"

This reverts commit 3c453e5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuijingHei · 2023-03-30T02:18:31Z

/retest

HuijingHei · 2023-03-30T07:33:56Z

https://github.com/openshift/os/blob/release-4.13/rhcos-packages.yaml#L18 includes toolbox, they might be duplicated?

travier · 2023-03-30T07:46:27Z

release-4.13/rhcos-packages.yaml#L18 includes toolbox, they might be duplicated?

This line above is to make sure the toolbox package is included.

This PR is to make sure it comes from the right repo so that we get the right version of it.

We now have a legacy toolbox build in the correct repo. This reverts commit 3c453e5.

openshift-ci-robot · 2023-03-30T07:57:42Z

@travier: This pull request references Jira Issue OCPBUGS-8009, which is invalid:

expected dependent Jira Issue OCPBUGS-8008 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "manifest: Back to rhel toolbox"

We now have a legacy toolbox build in the correct repo.

This reverts commit 3c453e5.

manifest/9/2: Get conmon-rs from rhel-9.2-server-ose-4.13 repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-30T07:57:47Z

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8009: Revert to legacy toolbox

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mike-nguyen · 2023-04-03T16:42:50Z

/lgtm

openshift-ci · 2023-04-03T16:48:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [HuijingHei,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sdodson · 2023-04-04T14:21:42Z

/label bugzilla/valid-bug
/label jira/valid-bug

travier · 2023-04-05T12:23:03Z

/jira refresh

openshift-ci-robot · 2023-04-05T12:23:08Z

@travier: This pull request references Jira Issue OCPBUGS-8009, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-8008 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-8008 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2023-04-05T12:25:32Z

I've manually verified toolbox in 4.14 and that conmon-rs is there in 4.13. Everything should be ready for this one.
/unhold

travier · 2023-04-05T12:26:48Z

CI is failure here is expected for now.
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

openshift-ci · 2023-04-05T12:29:22Z

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

Details

In response to this:

CI is failure here is expected for now.
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-04-05T12:41:35Z

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-04-05T12:46:17Z

@travier: Jira Issue OCPBUGS-8009: All pull requests linked via external trackers have merged:

openshift/os#1203

Jira Issue OCPBUGS-8009 has been moved to the MODIFIED state.

Details

In response to this:

Revert "manifest: Back to rhel toolbox"

We now have a legacy toolbox build in the correct repo.

This reverts commit 3c453e5.

manifest/9/2: Get conmon-rs from rhel-9.2-server-ose-4.13 repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2023

openshift-ci Bot requested review from HuijingHei and jschintag March 16, 2023 11:09

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2023

travier changed the title ~~kola-denylist: re-enable luks.* test on !x86_64~~ OCPBUGS-8008: Backports and revert to legacy toolbox Mar 16, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 16, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 16, 2023

travier changed the title ~~OCPBUGS-8008: Backports and revert to legacy toolbox~~ OCPBUGS-8009: Backports and revert to legacy toolbox Mar 16, 2023

openshift-ci Bot assigned HuijingHei Mar 16, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023

openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 20, 2023

openshift-ci-robot mentioned this pull request Mar 21, 2023

OCPBUGS-8008: manifest/9.2: Keep legacy coreos/toolbox & Revert "Ensure package come from RHEL by default" #1202

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2023

travier changed the title ~~OCPBUGS-8009: Backports and revert to legacy toolbox~~ OCPBUGS-8009: Revert to legacy toolbox Mar 29, 2023

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023

travier added 2 commits March 30, 2023 09:56

Revert "manifest: Back to rhel toolbox"

e8a932c

We now have a legacy toolbox build in the correct repo. This reverts commit 3c453e5.

manifest/9/2: Get conmon-rs from rhel-9.2-server-ose-4.13 repo

493984a

travier force-pushed the release-4.13-backports branch from 9b6f697 to 493984a Compare March 30, 2023 07:57

openshift-ci Bot assigned mike-nguyen Apr 3, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023

openshift-ci-robot mentioned this pull request Apr 4, 2023

OCPBUGS-8008: Revert "manifest: Back to rhel toolbox" #1221

Merged

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 4, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 5, 2023

openshift-ci Bot requested a review from mike-nguyen April 5, 2023 12:23

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023

openshift-merge-robot merged commit ee2b02f into openshift:release-4.13 Apr 5, 2023

travier deleted the release-4.13-backports branch April 5, 2023 13:30

Conversation

travier commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 16, 2023

Uh oh!

travier commented Mar 16, 2023

Uh oh!

openshift-ci Bot commented Mar 16, 2023

Uh oh!

openshift-ci-robot commented Mar 16, 2023

Uh oh!

openshift-ci Bot commented Mar 16, 2023

Uh oh!

openshift-ci-robot commented Mar 16, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

travier commented Mar 16, 2023

Uh oh!

openshift-ci-robot commented Mar 16, 2023

Uh oh!

HuijingHei commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HuijingHei commented Mar 16, 2023

Uh oh!

HuijingHei commented Mar 16, 2023

Uh oh!

travier commented Mar 16, 2023

Uh oh!

mike-nguyen commented Mar 20, 2023

Uh oh!

openshift-ci Bot commented Mar 29, 2023

Uh oh!

openshift-ci-robot commented Mar 29, 2023

Uh oh!

HuijingHei commented Mar 30, 2023

Uh oh!

HuijingHei commented Mar 30, 2023

Uh oh!

travier commented Mar 30, 2023

Uh oh!

openshift-ci-robot commented Mar 30, 2023

Uh oh!

openshift-ci Bot commented Mar 30, 2023

Uh oh!

mike-nguyen commented Apr 3, 2023

Uh oh!

openshift-ci Bot commented Apr 3, 2023

Uh oh!

sdodson commented Apr 4, 2023

Uh oh!

travier commented Apr 5, 2023

Uh oh!

openshift-ci-robot commented Apr 5, 2023

Uh oh!

travier commented Apr 5, 2023

Uh oh!

travier commented Apr 5, 2023

Uh oh!

openshift-ci Bot commented Apr 5, 2023

Uh oh!

openshift-ci Bot commented Apr 5, 2023

Uh oh!

openshift-ci-robot commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

travier commented Mar 16, 2023 •

edited

Loading

openshift-ci-robot commented Mar 16, 2023 •

edited by openshift-ci Bot

Loading

HuijingHei commented Mar 16, 2023 •

edited

Loading