Skip to content

OCPBUGS-8008: Revert "manifest: Back to rhel toolbox"#1221

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
travier:legacy-toolbox
Apr 4, 2023
Merged

OCPBUGS-8008: Revert "manifest: Back to rhel toolbox"#1221
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
travier:legacy-toolbox

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Mar 29, 2023

Revert "manifest: Back to rhel toolbox"

We now have a build of the legacy toolbox in the RHAOS repo.

This reverts commit cdeb252.

@openshift-ci openshift-ci Bot requested review from Adam0Brien and dustymabe March 29, 2023 17:16
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2023
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 29, 2023

In revert commits, I like to still include in the commit message why we're good to revert the thing now. But not a blocker.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2023
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 3abd461 and 2 for PR HEAD 5dd4003 in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@travier travier changed the title Revert "manifest: Back to rhel toolbox" OCPBUGS-8008: Revert "manifest: Back to rhel toolbox" Mar 30, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 30, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@travier: This pull request references Jira Issue OCPBUGS-8008, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Revert "manifest: Back to rhel toolbox"

We now have a build of the legacy toolbox in the RHAOS repo.

This reverts commit cdeb252.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from mike-nguyen March 30, 2023 09:14
We now have a build of the legacy toolbox in the RHAOS repo.

This reverts commit cdeb252.
@mike-nguyen
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jlebon,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD f8a59eb and 2 for PR HEAD c8a74be in total

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 4, 2023

Skipping failing c9s tests in #1238

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 4, 2023

Tested locally.

/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2023

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

Details

In response to this:

Tested locally.

/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2023

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 951caa6 into openshift:master Apr 4, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@travier: Jira Issue OCPBUGS-8008: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-8008 has not been moved to the MODIFIED state.

Details

In response to this:

Revert "manifest: Back to rhel toolbox"

We now have a build of the legacy toolbox in the RHAOS repo.

This reverts commit cdeb252.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier deleted the legacy-toolbox branch April 4, 2023 09:16
@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 4, 2023

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@travier: Jira Issue OCPBUGS-8008: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8008 has been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants