NO-JIRA: extensions/Dockerfile: use fedora-archive.repo and revert "use fedora:latest"#1603
Conversation
|
@marmijo: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
approved
marmijo
force-pushed
the
revert-extensions-releasever
branch
from
c499ca7 to
f66fc3b
Compare
A `fedora-archive.repo` file will now be used by older branches using EOL fedora container versions[1]. This now acts as our mechanism for handling the situation where the EOL Fedora content actually moves to a different location by pointing to the archived content directly. The `fedora-archive.repo` file in the testing-devel branch will be curled during the container setup instead of the `fedora.repo` file when the version goes EOL. This does mean we'll still have to maintain this container setup by updating the curl command as the versions go EOL around each new release. This reverts commit 94dfed8. [1] coreos/fedora-coreos-config#3128
marmijo
force-pushed
the
revert-extensions-releasever
branch
from
f66fc3b to
0392e6f
Compare
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the extensions container, which uses the fedora container, to utilize `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos/fedora-coreos-config#3145
|
/retitle NO-JIRA: extensions/Dockerfile: use fedora-archive.repo and revert "use fedora:latest" |
openshift-ci
Bot
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, marmijo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marmijo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Note this is flawed logic and I apologize if I somehow propagated it. The fedora-archive repo doesn't live forever and it's not really meant to support EOL releases. It was created originally to support a specific problem we were having: coreos/fedora-coreos-tracker#400 Periodically EOL releases in the archive repo get cleaned up. |
4 participants
A
fedora-archive.repofile will now be used by older branches using EOL fedora container versions[1]. This now acts as our mechanism for handling the situation where the EOL Fedora content actually moves to a different location by pointing to the archived content directly. Thefedora-archive.repofile in the testing-devel branch will be curled during the container setup instead of thefedora.repofile when the version goes EOL.This does mean we'll still have to maintain this container setup by updating the curl command as the versions go EOL around each new release.
This reverts commit 94dfed8.
[1] coreos/fedora-coreos-config#3128
EDIT:
We can actually now use the
fedora-archive.repofor both EOL and non-EOL fedora releases. We decided to use it for the extensions container so we dont have to swap outfedora.repowhen versions go EOL. Make that change here too.