Skip to content

extensions/Dockerfile: Update to Fedora 42#1808

Closed
aaradhak wants to merge 1 commit into
openshift:masterfrom
aaradhak:f42
Closed

extensions/Dockerfile: Update to Fedora 42#1808
aaradhak wants to merge 1 commit into
openshift:masterfrom
aaradhak:f42

Conversation

@aaradhak
Copy link
Copy Markdown
Contributor

@openshift-ci openshift-ci Bot requested review from Roshan-R and marmijo April 28, 2025 20:42
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
Copy link
Copy Markdown
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread extensions/Dockerfile
## This uses Fedora as a lowest-common-denominator because it will work on
## current p8/s390x. See https://github.com/openshift/os/issues/1000
FROM quay.io/fedora/fedora:41 as builder
FROM quay.io/fedora/fedora:42 as builder
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlebon @travier - should we consider switching back to centos stream9 here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 89% sure we can and should, yes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK if we only build RHEL9 now. I think that's the case but I've not 100% verified.

Comment thread extensions/Dockerfile
FROM quay.io/fedora/fedora:42 as builder
COPY --from=os /usr/share/rpm-ostree/extensions/ /usr/share/rpm-ostree/extensions/
RUN rm -f /etc/yum.repos.d/*.repo \
&& curl -L https://raw.githubusercontent.com/coreos/fedora-coreos-config/testing-devel/fedora-archive.repo -o /etc/yum.repos.d/fedora-archive.repo
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we are pulling in the archive repo here. This should probably be dropped.

Copy link
Copy Markdown
Contributor

@marmijo marmijo Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll still need to keep this while we are building on the ITUP cluster: 8301c67
EDIT: 51d07e8

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also..

keep this while we are building on the ITUP cluster

we need it while building on the ITUP cluster because it doesn't use a mirrorlist?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2025

@aaradhak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 285ad9c link false /test e2e-aws
ci/prow/rhcos-9-build-test-qemu 285ad9c link true /test rhcos-9-build-test-qemu
ci/prow/okd-scos-e2e-aws-ovn 285ad9c link false /test okd-scos-e2e-aws-ovn
ci/prow/scos-9-build-test-metal 285ad9c link true /test scos-9-build-test-metal
ci/prow/scos-10-build-test-metal 285ad9c link true /test scos-10-build-test-metal
ci/prow/okd-scos-images 285ad9c link true /test okd-scos-images
ci/prow/rhcos-9-build-test-metal 285ad9c link true /test rhcos-9-build-test-metal
ci/prow/scos-9-build-test-qemu 285ad9c link true /test scos-9-build-test-qemu
ci/prow/scos-10-build-test-qemu 285ad9c link true /test scos-10-build-test-qemu

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustymabe
Copy link
Copy Markdown
Member

added a commit to #1759 that switches to stream9 here.

@dustymabe dustymabe closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants