NO-JIRA: ci/get-ocp-repo.sh: add --enablerepo when installing centos packages#1762
Conversation
| fi | ||
| cat "$workdir/c9s.repo" >> "$repo_path.tmp" | ||
| mv "$repo_path.tmp" "$repo_path" | ||
| # copy the repo file to /etc/yum.repos.d - this is needed when building extensions as we need to install |
There was a problem hiding this comment.
i'm wondering if a better solution is to not do dnf remove on the centos-release packages during cleanup and avoid this altogether. I don't see any harm in those packages being around
There was a problem hiding this comment.
I just read through the other PR comments and if I understand what's happening I think we need to cleanup otherwise the ci repos definitions will stick in the image and mess things down the line, as in https://issues.redhat.com/browse/OCPBUGS-52363
There was a problem hiding this comment.
yes we can keep the repo cleanup as such (removing the ocp.repo file), but instead of doing this - I wonder if we can just keep the centos packages around.
There was a problem hiding this comment.
Not against keeping the repo files around for SCOS if you'd like. The reason I suggested that is for parity with RHCOS, where we don't either keep any repo files around in the image.
That said, I don't think that's actually the issue here. Isn't the problem actually that the repos are disabled? The default ones (e.g. baseos and appstream) at least should definitely still be there, but in postprocess we disable it (that's the sed you fixed in the previous PR).
There was a problem hiding this comment.
So basically, instead of this, try just adding --enablerepo baseos --enablerepo appstream to the dnf install invocation in create_gpg_keys.
There was a problem hiding this comment.
oh..right because we only remove the ocp.repo and not the others. thanks @jlebon I missed that.
|
/retest |
Prashanth684
force-pushed
the
okd-scos-extensions-fix
branch
2 times, most recently
from
5fd11cb to
587059a
Compare
Prashanth684
changed the title
This PR: openshift/release#62296 now builds scos images. The extensions image build hit this error: ``` INFO: Neutering RHEL repos for SCOS centos-stream-release-9.0-26.el9.noarch package centos-release-cloud is not installed Updating Subscription Management repositories. Unable to read consumer identity This system is not registered with an entitlement server. You can use subscription-manager to register. Error: There are no enabled repositories in "/etc/yum.repos.d", "/etc/yum/repos.d", "/etc/distro.repos.d". ``` This is because the centos-release* repos are disabled in the node image which is used for building extensions
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Prashanth684
changed the title
|
@Prashanth684: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
1 similar comment
|
/override ci/prow/rhcos-9-build-test-metal |
|
@Prashanth684: Overrode contexts on behalf of Prashanth684: ci/prow/e2e-aws, ci/prow/rhcos-9-build-test-metal, ci/prow/scos-9-build-test-metal DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Prashanth684: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This PR: openshift/release#62296 now builds scos images. The extensions image build hit this error:
This is because the centos-release* repos are disabled in the node image which is used for building extensions