Skip to content

openshift/os: start building scos node images#62296

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
Prashanth684:okd-scos
Mar 11, 2025
Merged

openshift/os: start building scos node images#62296
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
Prashanth684:okd-scos

Conversation

@Prashanth684
Copy link
Copy Markdown
Contributor

@Prashanth684 Prashanth684 commented Mar 3, 2025

  • build the stream-coreos and stream-coreos-extensions images which is used in OKD releases
  • promote these images to the scos imagestream as they will be used as the node images going forward in lieu of the m-o-c pipeline

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/hold

@Prashanth684
Copy link
Copy Markdown
Contributor Author

depends on openshift/os#1757

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2025
@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-os-master-images

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: job(s): pull-ci-openshift-os-master-images either don't exist or were not found to be affected, and cannot be rehearsed

Prashanth684 added a commit to Prashanth684/os that referenced this pull request Mar 6, 2025
…xtensions container for scos

This PR: openshift/release#62296 now builds scos
images. The extensions image build hit this error:

```
INFO: Neutering RHEL repos for SCOS
centos-stream-release-9.0-26.el9.noarch
package centos-release-cloud is not installed
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Error: There are no enabled repositories in "/etc/yum.repos.d", "/etc/yum/repos.d", "/etc/distro.repos.d".
```

This is because the centos-release* repos are not installed in the base
image as we clean them up and remove the repo file. We need to copy it
gain to /etc/yum.repos.d so these repos can be re-installed
- registry.access.redhat.com/ubi9/ubi:latest
stream-coreos:
as:
- registry.ci.openshift.org/rhcos-devel/rhel-coreos:latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will build the okd node image on top of rhel-coreos, which is unwanted.
We should use the c9s base image but we don't publish it to registry.ci as of now.
We can change that though

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI according to https://docs.ci.openshift.org/docs/architecture/images/#ci-images, the extensions will be built on top of the previously built stream-coreos image which is substituted for the registry.ci.openshift.org/rhcos-devel/rhel-coreos:latest. This is similar to what is done for rhel-coreos

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbtrystram this is now ready to go. Do you have any other concerns before approval?

Copy link
Copy Markdown
Contributor Author

@Prashanth684 Prashanth684 Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will build the okd node image on top of rhel-coreos, which is unwanted.

The default in the Containerfile of the os repo is a c9s base image (quay.io/openshift-release-dev/ocp-v4.0-art-dev:c9s-coreos) - and that is used to build the stream-coreos image which is then used to build the extensions. hope this makes it clear.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use the same default in both TBH, but no need to block on that.

Prashanth684 added a commit to Prashanth684/os that referenced this pull request Mar 6, 2025
…xtensions container for scos

This PR: openshift/release#62296 now builds scos
images. The extensions image build hit this error:

```
INFO: Neutering RHEL repos for SCOS
centos-stream-release-9.0-26.el9.noarch
package centos-release-cloud is not installed
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Error: There are no enabled repositories in "/etc/yum.repos.d", "/etc/yum/repos.d", "/etc/distro.repos.d".
```

This is because the centos-release* repos are not installed in the base
image as we clean them up and remove the repo file. We need to copy it
gain to /etc/yum.repos.d so these repos can be re-installed
Prashanth684 added a commit to Prashanth684/os that referenced this pull request Mar 6, 2025
This PR: openshift/release#62296 now builds scos
images. The extensions image build hit this error:

```
INFO: Neutering RHEL repos for SCOS
centos-stream-release-9.0-26.el9.noarch
package centos-release-cloud is not installed
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Error: There are no enabled repositories in "/etc/yum.repos.d", "/etc/yum/repos.d", "/etc/distro.repos.d".
```

This is because the centos-release* repos are disabled in the node image
which is used for building extensions
@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-os-master-okd-scos-images

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2025
@Prashanth684
Copy link
Copy Markdown
Contributor Author

/cc @jlebon

@openshift-ci openshift-ci Bot requested a review from jlebon March 10, 2025 14:27
Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!
/lgtm

Comment thread ci-operator/config/openshift/os/openshift-os-master__okd-scos.yaml Outdated
- registry.access.redhat.com/ubi9/ubi:latest
stream-coreos:
as:
- registry.ci.openshift.org/rhcos-devel/rhel-coreos:latest
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use the same default in both TBH, but no need to block on that.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@jupierce
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
- build the stream-coreos and stream-coreos-extensions images which is
  used in OKD releases
- promote these images to the scos imagestream as they will be used as
  the node images going forward in favour of the m-o-c pipeline
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 11, 2025

@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/os/master/okd-scos-e2e-aws-ovn 885583e link unknown /pj-rehearse pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prashanth684: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn openshift/os presubmit Presubmit changed
pull-ci-openshift-os-master-okd-scos-images openshift/os presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Prashanth684
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@Prashanth684: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 11, 2025
@ausil
Copy link
Copy Markdown
Contributor

ausil commented Mar 11, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ausil, jlebon, jupierce, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 0fffc8c into openshift:master Mar 11, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 11, 2025

@Prashanth684: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_scos-4_19 using file core-services/image-mirroring/openshift/mapping_origin_scos-4_19
Details

In response to this:

  • build the stream-coreos and stream-coreos-extensions images which is used in OKD releases
  • promote these images to the scos imagestream as they will be used as the node images going forward in lieu of the m-o-c pipeline

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Prashanth684 added a commit to Prashanth684/release that referenced this pull request Mar 12, 2025
…mTag

Now that we have images being generated through openshift#62296, we no longer
need this
Prashanth684 added a commit to Prashanth684/release that referenced this pull request Mar 12, 2025
…mTag

Now that we have images being generated through openshift#62296, we no longer
need this
openshift-merge-bot Bot pushed a commit that referenced this pull request Mar 12, 2025
…mTag (#62682)

Now that we have images being generated through #62296, we no longer
need this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants