ci: Rework to split build/test#513
Merged
Merged
Conversation
Aiming to fix openshift#506 I think the problem here may be related to the fact that we're trying to do all of our CI as part of a build. Instead, let's function like e.g. the CI for coreos/rpm-ostree which creates a derived container from the source code. For us, this derived container is basically the 2-tuple (source, cosa). For coreos/rpm-ostree we actually do generate binaries as well as test code from the buildroot, i.e. a 3 tuple (binaries, test binaries, cosa). But here we don't need that, there's no actual "build" step. Split off `validate.sh` as a separate thing that can be a clearly separate step.
openshift-ci-robot
added
the
approved
Member
Author
|
Should pair with openshift/release#16649 |
Member
Author
|
Note that the reason this PR passed is that I neutered the CI back to just running |
Member
|
🤞 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
added a commit
to cgwalters/release
that referenced
this pull request
Mar 10, 2021
Requires: openshift/os#513 Aiming to fix openshift/os#506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiming to fix #506
I think the problem here may be related to the fact that
we're trying to do all of our CI as part of a build.
Instead, let's function like e.g. the CI for coreos/rpm-ostree
which creates a derived container from the source code. For
us, this derived container is basically the 2-tuple (source, cosa).
For coreos/rpm-ostree we actually do generate binaries as well
as test code from the buildroot, i.e. a 3 tuple (binaries, test binaries, cosa).
But here we don't need that, there's no actual "build" step.
Split off
validate.shas a separate thing that can be aclearly separate step.