Skip to content

[rhel8.5 revert] Use RHEL8.6 repo for kata-containers#796

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mike-nguyen:86_kata_extension
May 7, 2022
Merged

[rhel8.5 revert] Use RHEL8.6 repo for kata-containers#796
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mike-nguyen:86_kata_extension

Conversation

@mike-nguyen
Copy link
Copy Markdown
Member

Reverting back to RHEL 8.5 content caused extension building to fail
because the newer kata-container has a requirement on a qemu-kvm-core
version that is newer than the one in the rhel-8-advanced-virt repo.

Get the kata-containers dependencies from RHEL8.6 appstream.

See: #795

Reverting back to RHEL 8.5 content caused extension building to fail
because the newer kata-container has a requirement on a qemu-kvm-core
version that is newer than the one in the rhel-8-advanced-virt repo.

Get the kata-containers dependencies from RHEL8.6 appstream.

See: openshift#795
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2022

@mike-nguyen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[rhel8.5 revert] Use RHEL8.6 repo for kata-containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from marmijo and sohankunkerkar May 6, 2022 19:10
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@miabbott
Copy link
Copy Markdown
Member

miabbott commented May 6, 2022

Should be able to target master with this PR, right?

@miabbott
Copy link
Copy Markdown
Member

miabbott commented May 6, 2022

I think you'll need to change the CI script to curl down the 8.6 repos and populate the ocp.repo file accordingly

@miabbott
Copy link
Copy Markdown
Member

miabbott commented May 6, 2022

I think you'll need to change the CI script to curl down the 8.6 repos and populate the ocp.repo file accordingly

I think I have a one-liner to do this, will push a commit to this PR

In order to keep successfully building the extensions, we need access
to the RHEL 8.6 Beta repo to fetch the `qemu-kvm-core` dependency that
`kata-containers` now requires.

This is a one-liner that fetches the 8.6 repos, greps for the
Appstream definition, and replaces the name/id. The output is written
to the existing `ocp.repo` file.
@miabbott miabbott changed the base branch from release-4.11 to master May 6, 2022 19:42
@mike-nguyen
Copy link
Copy Markdown
Member Author

Second commit looks good to me

@mike-nguyen
Copy link
Copy Markdown
Member Author

/test build-test-qemu

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2022

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miabbott
Copy link
Copy Markdown
Member

miabbott commented May 7, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, miabbott, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,miabbott,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 53abd37 into openshift:master May 7, 2022
miabbott added a commit to miabbott/os that referenced this pull request May 23, 2022
The introduction of new Prow periodic jobs (openshift/release#27779)
means we have to keep the `prow-build.sh` and
`prow-build-test-qemu.sh` scripts in sync, with regards to fetching
the repo configs.

This brings `prow-build.sh` in sync with the changes from openshift#796.

Closes openshift#801
miabbott added a commit to miabbott/os that referenced this pull request May 25, 2022
The introduction of new Prow periodic jobs (openshift/release#27779)
means we have to keep the `prow-build.sh` and
`prow-build-test-qemu.sh` scripts in sync, with regards to fetching
the repo configs.

This brings `prow-build.sh` in sync with the changes from openshift#796.

Closes openshift#801
miabbott added a commit to miabbott/os that referenced this pull request May 25, 2022
The introduction of new Prow periodic jobs (openshift/release#27779)
means we have to keep the `prow-build.sh` and
`prow-build-test-qemu.sh` scripts in sync, with regards to fetching
the repo configs.

This brings `prow-build.sh` in sync with the changes from openshift#796.

Closes openshift#801
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/os that referenced this pull request Jun 3, 2022
The introduction of new Prow periodic jobs (openshift/release#27779)
means we have to keep the `prow-build.sh` and
`prow-build-test-qemu.sh` scripts in sync, with regards to fetching
the repo configs.

This brings `prow-build.sh` in sync with the changes from openshift#796.

Closes openshift#801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants