Skip to content

ci: fix prow-build.sh to fetch same repos#802

Merged
cgwalters merged 1 commit intoopenshift:masterfrom
miabbott:fix_periodics
Jun 1, 2022
Merged

ci: fix prow-build.sh to fetch same repos#802
cgwalters merged 1 commit intoopenshift:masterfrom
miabbott:fix_periodics

Conversation

@miabbott
Copy link
Copy Markdown
Member

The introduction of new Prow periodic jobs (openshift/release#27779)
means we have to keep the prow-build.sh and
prow-build-test-qemu.sh scripts in sync, with regards to fetching
the repo configs.

This brings prow-build.sh in sync with the changes from #796.

Closes #801

@openshift-ci openshift-ci Bot requested review from bgilbert and ravanelli May 23, 2022 16:58
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2022
@miabbott miabbott marked this pull request as draft May 23, 2022 17:19
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2022
@miabbott
Copy link
Copy Markdown
Member Author

/test validate

@miabbott
Copy link
Copy Markdown
Member Author

/test validate

@miabbott
Copy link
Copy Markdown
Member Author

Chasing down the new failure in openshift/release#28790

miabbott added a commit to miabbott/release that referenced this pull request May 24, 2022
The `validate` job started to fail with:

```
fatal: unsafe repository ('/go/src/github.com/openshift/os' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /go/src/github.com/openshift/os
```

Applying this suggestion as part of the `ci/validate.sh` script
(see openshift/os#802) fails with the error:

```
+ git config --global --add safe.directory /go/src/github.com/openshift/os
error: could not lock config file //.gitconfig: Permission denied
```

I suspect this is related to how the random user ID is configured in
OCP pods, similar to what is described in openshift/os#781, so I tried
using the `ci/set-openshift-user.sh` script as part of the `validate`
job.

Through trial and error, I found that using the `fcos-buildroot`
container based on F36 would not work with this change and had to
switch to using the `cosa:latest` container. Going further down the
rabbit hole, I found that I didn't need to use the
`ci/set-openshift-user.sh` script at all and just the `cosa:latest`
container was enough to get the `validate` job to pass. I don't claim
to fully understand why this is the case, but it does effectively
unblock the `validate` job.
@miabbott
Copy link
Copy Markdown
Member Author

/test validate

@miabbott
Copy link
Copy Markdown
Member Author

/test validate

The introduction of new Prow periodic jobs (openshift/release#27779)
means we have to keep the `prow-build.sh` and
`prow-build-test-qemu.sh` scripts in sync, with regards to fetching
the repo configs.

This brings `prow-build.sh` in sync with the changes from openshift#796.

Closes openshift#801
@miabbott miabbott marked this pull request as ready for review May 25, 2022 17:27
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2022
@openshift-ci openshift-ci Bot requested a review from prestist May 25, 2022 17:28
@HuijingHei
Copy link
Copy Markdown
Contributor

/retest

Copy link
Copy Markdown
Contributor

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miabbott
Copy link
Copy Markdown
Member Author

/retest

@miabbott
Copy link
Copy Markdown
Member Author

miabbott commented May 31, 2022

INFO[2022-05-31T17:12:59Z] Build cosa-build succeeded after 3h5m10s

The cosa-build portion of the jobs is taking an excessively long time to complete due to what I believe is a lack of adequate resources; see openshift/release#29031

@cgwalters
Copy link
Copy Markdown
Member

OK, this is just failing on the bits that should be fixed in #810
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, HuijingHei, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,cgwalters,miabbott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 2 against base HEAD 9d5d660 and 8 for PR HEAD a939a71 in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 1 against base HEAD 9d5d660 and 7 for PR HEAD a939a71 in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 9d5d660 and 6 for PR HEAD a939a71 in total

@cgwalters
Copy link
Copy Markdown
Member

/override ci/prow/test-in-cluster
/override ci/prow/test-qemu-metal

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/test-in-cluster, ci/prow/test-qemu-metal

Details

In response to this:

/override ci/prow/test-in-cluster
/override ci/prow/test-qemu-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Copy Markdown
Member

Forcing merge to get our CI going.

@cgwalters cgwalters merged commit 16f7668 into openshift:master Jun 1, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2022

@miabbott: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images a939a71 link unknown /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Copy Markdown
Member

/cherrypick release-4.11

@openshift-cherrypick-robot
Copy link
Copy Markdown

@cgwalters: new pull request created: #813

Details

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new periodic jobs are failing on a missing repo

5 participants