Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 by HuijingHei · Pull Request #830 · openshift/os

HuijingHei · 2022-06-08T05:38:02Z

This allows us to land OCP specific changes to conmon and
potentially ship newer versions than what would available in the module.

openshift-ci · 2022-06-08T05:38:05Z

@HuijingHei: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

manifest: pull conmon pkg from RHAOS repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HuijingHei · 2022-06-08T07:42:04Z

/retest

travier

LGTM, one nit

This allows us to land OCP specific changes to conmon and potentially ship newer versions than what would available in the module.

joepvd · 2022-06-08T08:48:10Z

/retest

travier · 2022-06-08T09:15:51Z

This needs a manual backport of #814. I'm working on it.

travier · 2022-06-08T09:22:58Z

#831

travier · 2022-06-08T09:37:12Z

/retitle Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo

openshift-ci · 2022-06-08T09:37:16Z

@HuijingHei: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2022-06-08T09:37:31Z

/retitle Bug 2094777: manifest: pull conmon pkg from RHAOS repo

openshift-ci · 2022-06-08T09:37:38Z

@HuijingHei: This pull request references Bugzilla bug 2094777, which is invalid:

expected Bugzilla bug 2094777 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2094777: manifest: pull conmon pkg from RHAOS repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2022-06-08T09:45:12Z

/bugzilla refresh

openshift-ci · 2022-06-08T09:45:18Z

@travier: This pull request references Bugzilla bug 2094777, which is invalid:

expected dependent Bugzilla bug 2094041 to target a release in 4.11.0, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2022-06-08T09:49:51Z

/bugzilla refresh

openshift-ci · 2022-06-08T09:50:00Z

@travier: This pull request references Bugzilla bug 2094777, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.z) matches configured target release for branch (4.10.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2094781 is in the state CLOSED (CURRENTRELEASE), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2094781 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mike-nguyen · 2022-06-08T12:54:48Z

/lgtm

miabbott · 2022-06-08T12:55:21Z

In build-test-qemu, the version of cosa is out of date; the Ignition tests are fetching from the old fixture bucket

[ 19.109940] ignition[897]: INFO : files: createFilesystemsFiles: createFiles: op(3): GET http://rh-kola-fixtures.s3.amazonaws.com/resources/anonymous: attempt #1

I'll see if I can trigger a new build of cosa:4.10 on the cluster

travier · 2022-06-08T13:11:54Z

/retitle Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10

openshift-ci-robot · 2022-06-08T13:33:18Z

/retest-required

Remaining retests: 2 against base HEAD b7fdd0c and 8 for PR HEAD 0e3cddb in total

cgwalters · 2022-06-08T13:42:42Z

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

miabbott · 2022-06-08T13:58:52Z

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

Agreed.

/override ci/prow/build-test-qemu
/override ci/prow/validate

/meow

openshift-ci · 2022-06-08T13:58:57Z

@miabbott:

Details

In response to this:

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

Agreed.

/override ci/prow/build-test-qemu
/override ci/prow/validate

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott · 2022-06-08T14:00:48Z

I'll see if I can trigger a new build of cosa:4.10 on the cluster

FYI, all cosa tags on the cluster have been updated to latest per branch

openshift-ci · 2022-06-08T14:01:40Z

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu, ci/prow/validate

Details

In response to this:

Not sure we should block on getting our full CI working for this, we only barely cover conmon via basic podman/crio testing, and those passed.

Agreed.

/override ci/prow/build-test-qemu
/override ci/prow/validate

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jmarrero

/lgtm
/approve

openshift-ci · 2022-06-08T14:05:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, jmarrero, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [HuijingHei,jmarrero,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-06-08T14:25:52Z

@HuijingHei: All pull requests linked via external trackers have merged:

openshift/os#830

Bugzilla bug 2094777 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-06-08T14:26:20Z

@HuijingHei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/validate	`0e3cddb`	link	true	`/test validate`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci Bot requested review from dustymabe and jmarrero June 8, 2022 05:38

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022

travier reviewed Jun 8, 2022

View reviewed changes

Comment thread manifest.yaml Outdated

travier reviewed Jun 8, 2022

View reviewed changes

manifest: pull conmon pkg from RHAOS repo

0e3cddb

This allows us to land OCP specific changes to conmon and potentially ship newer versions than what would available in the module.

HuijingHei force-pushed the conmon_rhaos branch from 16e8fea to 0e3cddb Compare June 8, 2022 08:06

openshift-ci Bot changed the title ~~manifest: pull conmon pkg from RHAOS repo~~ Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo Jun 8, 2022

openshift-ci Bot changed the title ~~Bugzilla 2094777: manifest: pull conmon pkg from RHAOS repo~~ Bug 2094777: manifest: pull conmon pkg from RHAOS repo Jun 8, 2022

openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022

openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022

openshift-ci Bot requested a review from mike-nguyen June 8, 2022 09:50

mike-nguyen approved these changes Jun 8, 2022

View reviewed changes

openshift-ci Bot assigned mike-nguyen Jun 8, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022

openshift-ci Bot changed the title ~~Bug 2094777: manifest: pull conmon pkg from RHAOS repo~~ Bug 2094777: manifest: pull conmon pkg from RHAOS repo for 4.10 Jun 8, 2022

jmarrero approved these changes Jun 8, 2022

View reviewed changes

openshift-ci Bot assigned jmarrero Jun 8, 2022

miabbott mentioned this pull request Jun 8, 2022

Bug 2094799: manifest: pull conmon from RHAOS repo for 4.9 #832

Merged

openshift-merge-robot merged commit bf606d1 into openshift:release-4.10 Jun 8, 2022

HuijingHei deleted the conmon_rhaos branch June 8, 2022 14:41

Conversation

HuijingHei commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

HuijingHei commented Jun 8, 2022

Uh oh!

Uh oh!

travier left a comment

Choose a reason for hiding this comment

Uh oh!

joepvd commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

mike-nguyen commented Jun 8, 2022

Uh oh!

miabbott commented Jun 8, 2022

Uh oh!

travier commented Jun 8, 2022

Uh oh!

openshift-ci-robot commented Jun 8, 2022

Uh oh!

cgwalters commented Jun 8, 2022

Uh oh!

miabbott commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

miabbott commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

jmarrero left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

openshift-ci Bot commented Jun 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants