Skip to content

[4.10] ci: Work around git checkout security check#831

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.10from
travier:4.10-ci-git-check
Jun 8, 2022
Merged

[4.10] ci: Work around git checkout security check#831
openshift-merge-robot merged 1 commit intoopenshift:release-4.10from
travier:4.10-ci-git-check

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Jun 8, 2022

Manual backport of #814

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 8, 2022

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

gitmodules: change branch to rhcos-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier changed the title gitmodules: change branch to rhcos-4.10 ci: Work around git checkout security check Jun 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 8, 2022

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

ci: Work around git checkout security check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from HuijingHei and dustymabe June 8, 2022 09:20
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 8, 2022

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

ci: Work around git checkout security check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 8, 2022

/lgtm

The validate job appears to be using the CI job config for master, not `release-4.10

/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 8, 2022

/lgtm

The validate job appears to be using the CI job config for master, not `release-4.10

/retest

/lgtm cancel

Ugh, too early in the morning to do this....

The commit is using cosa init --transient which isn't on the rhcos-4.10 branch of cosa

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 8, 2022

@travier we'll need a different workaround for the unsafe git checkout problem

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@travier travier changed the title ci: Work around git checkout security check [4.10] ci: Work around git checkout security check Jun 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 8, 2022

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[4.10] ci: Work around git checkout security check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier force-pushed the 4.10-ci-git-check branch 2 times, most recently from aff5ea7 to b0fb98c Compare June 8, 2022 13:57
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 8, 2022

+ git clone /src
fatal: repository '/src' does not exist

Looks like the correct path would be /go/src/github/openshift/os based on

COPY --from=builder /go/src/github.com/openshift/os/layering_test /usr/local/bin/layering_test

Edit: Maybe? I'm not 100% sure actually 😓

@travier travier force-pushed the 4.10-ci-git-check branch from b0fb98c to 6dbc52a Compare June 8, 2022 18:57
@travier travier force-pushed the 4.10-ci-git-check branch from 6dbc52a to e45486c Compare June 8, 2022 19:04
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 8, 2022

OK, looks like this workaround works

@cgwalters
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 8, 2022

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 95e356e into openshift:release-4.10 Jun 8, 2022
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 9, 2022

/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

@travier: cannot checkout 4.9: error checking out 4.9: exit status 1. output: error: pathspec '4.9' did not match any file(s) known to git

Details

In response to this:

/cherry-pick 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 9, 2022

/cherrypick release-4.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

@travier: new pull request created: #835

Details

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier deleted the 4.10-ci-git-check branch June 9, 2022 08:29
@HuijingHei
Copy link
Copy Markdown
Contributor

/cherrypick release-4.11

@openshift-cherrypick-robot
Copy link
Copy Markdown

@HuijingHei: new pull request created: #837

Details

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants