Skip to content

ci: Remove version selection script#882

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
travier:ci-remove-select-script
Jul 8, 2022
Merged

ci: Remove version selection script#882
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
travier:ci-remove-select-script

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Jul 7, 2022 •
edited
Loading

Remove the current multi-version setup that was merged in #852 as we are moving to a COSA based setup.

@travier
ci: Remove version selection script
d2f2646 
Remove the current multi-version setup that was merged in
openshift#852 as we are moving to a COSA
based setup.
@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 7, 2022

I'm removing that now before the alternative is ready to avoid creating dependencies on it.

@openshift-ci openshift-ci Bot requested review from cgwalters and mike-nguyen July 7, 2022 16:47
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022
@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 7, 2022

/retest

@travier travier mentioned this pull request Jul 8, 2022
Closed
@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 8, 2022

CC @jlebon

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jul 8, 2022

Remove the current multi-version setup that was merged in #852 as we are moving to a COSA based setup.

This looks fine, but is there context/breadcrumbs on how we are going to select the version via coreos-assembler?

@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 8, 2022

Yes, the plan for COSA is in coreos/coreos-assembler#2934

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jul 8, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miabbott, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2022

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit aa5a741 into openshift:master Jul 8, 2022
@travier travier deleted the ci-remove-select-script branch July 11, 2022 16:35
travier added a commit to travier/release that referenced this pull request Jul 12, 2022
@travier
ci-operator/openshift/os: Remove 8.6 references
ed90428 
Remove RHEL 8.6 references and use unversioned names for images until we
have figured out how we will support RHCOS 9.

See:
- openshift#30351
- openshift/os#882
@travier travier mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@miabbott miabbott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@travier @miabbott