Skip to content

reenable nightly rhcos build#30134

Closed
cheesesashimi wants to merge 1 commit intoopenshift:masterfrom
cheesesashimi:zzlotnik/reenable-nightly-rhcos-builds
Closed

reenable nightly rhcos build#30134
cheesesashimi wants to merge 1 commit intoopenshift:masterfrom
cheesesashimi:zzlotnik/reenable-nightly-rhcos-builds

Conversation

@cheesesashimi
Copy link
Copy Markdown
Member

@cheesesashimi cheesesashimi commented Jul 5, 2022

This re-enables the nightly RHCOS builds to push to registry.ci.openshift.org/rhcos-devel/rhel-coreos:latest.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot requested review from aaradhak and prestist July 5, 2022 18:36
@cheesesashimi cheesesashimi force-pushed the zzlotnik/reenable-nightly-rhcos-builds branch 6 times, most recently from 8645cf9 to ca5f1b3 Compare July 6, 2022 21:15
@cheesesashimi cheesesashimi marked this pull request as ready for review July 6, 2022 21:21
@cheesesashimi
Copy link
Copy Markdown
Member Author

cheesesashimi commented Jul 6, 2022

/assign cgwalters

@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2022
@openshift-ci openshift-ci Bot requested review from ravanelli and travier July 6, 2022 21:24
cgwalters
cgwalters approved these changes Jul 6, 2022
View reviewed changes
Comment thread ci-operator/config/openshift/os/openshift-os-master__periodic.yaml Outdated
Copy link
Copy Markdown
Member

@cgwalters cgwalters Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm do we really need this?

Copy link
Copy Markdown
Member Author

@cheesesashimi cheesesashimi Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to make the Dockerfile reusable for once we have additional RHELVER. I wanted it to fail fast if the wrong RHELVER was used, but I can make it default to something else.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Jul 6, 2022

Worth trying anyways, let's do any fixes as followups
/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2022
@travier
Copy link
Copy Markdown
Member

travier commented Jul 6, 2022

/hold
I'll take a look tomorrow

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 6, 2022

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/os/master/periodic-experiment-with-pushing-to-imagestream-from-test d0549eb0e24b84fabe4c289ff4e342b9a1a6c322 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

travier
travier reviewed Jul 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but mostly LGTM

Comment thread ci-operator/config/openshift/os/openshift-os-master__periodic.yaml Outdated
Copy link
Copy Markdown
Member

@travier travier Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Dockerfiles need to stay here to avoid the issue where Prow uses only the current one from the branch during the test

Copy link
Copy Markdown
Member Author

@cheesesashimi cheesesashimi Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know Prow does some image build caching if you use build_root to point to a Dockerfile in your repo. I didn't realize it also did that if you used a dockerfile_path like this.

Copy link
Copy Markdown
Member

@travier travier Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image hum, it's not clear indeed how safe it is to have non-buildroot images inside the repo

Comment thread ci-operator/config/openshift/os/openshift-os-master__periodic.yaml Outdated
Copy link
Copy Markdown
Member

@travier travier Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably only want to test the default one here so we don't need this logic. COSA will be able to figure out the default by itself in the future.

Copy link
Copy Markdown
Member Author

@cheesesashimi cheesesashimi Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me. I'll update the RHELVER build arg default to rhel-8.6.

@cheesesashimi cheesesashimi force-pushed the zzlotnik/reenable-nightly-rhcos-builds branch from ca5f1b3 to 18e5ce3 Compare July 7, 2022 13:44
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@cheesesashimi cheesesashimi mentioned this pull request Jul 7, 2022
Closed
@cheesesashimi cheesesashimi force-pushed the zzlotnik/reenable-nightly-rhcos-builds branch from 18e5ce3 to 8287e76 Compare July 7, 2022 14:18
@travier
Copy link
Copy Markdown
Member

travier commented Jul 7, 2022

/lgtm

@travier
Copy link
Copy Markdown
Member

travier commented Jul 7, 2022

Let's wait until CI is green and then unhold

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cheesesashimi, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheesesashimi
Copy link
Copy Markdown
Member Author

cheesesashimi commented Jul 7, 2022

Let's wait until CI is green and then unhold

Fine with me. FYI: Disregard any failure messages related to ci/rehearse/openshift/os/master/periodic-experiment-with-pushing-to-imagestream-from-test. That was an experiment I tried and later gave up on.

@travier
Copy link
Copy Markdown
Member

travier commented Jul 7, 2022

Hum, I'm updating the CoreOS layering PR and I found things to change in this one so I'll push an alternative.

@jmarrero jmarrero mentioned this pull request Jul 7, 2022
Closed
@cheesesashimi
Copy link
Copy Markdown
Member Author

cheesesashimi commented Jul 7, 2022

Hum, I'm updating the CoreOS layering PR and I found things to change in this one so I'll push an alternative.

Do you mean that you'll fork this PR, add your changes and open a new PR (or append to #30019)? Or would you like me to add some of your changes into this one?

@travier
Copy link
Copy Markdown
Member

travier commented Jul 8, 2022 •
edited
Loading

Related to openshift/os#882

@travier
Copy link
Copy Markdown
Member

travier commented Jul 8, 2022

I've made #30276. Not sure I can push here.

@cheesesashimi
Copy link
Copy Markdown
Member Author

cheesesashimi commented Jul 11, 2022

This PR has been superceded by #30276. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaradhak aaradhak Awaiting requested review from aaradhak

@prestist prestist Awaiting requested review from prestist

@ravanelli ravanelli Awaiting requested review from ravanelli

2 more reviewers

@travier travier travier left review comments

@cgwalters cgwalters cgwalters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cgwalters cgwalters

@travier travier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cheesesashimi @cgwalters @travier