Skip to content

ci-operator/openshift/os: Re-add CoreOS layering test#30019

Closed
travier wants to merge 1 commit intoopenshift:masterfrom
travier:rhcos-layering
Closed

ci-operator/openshift/os: Re-add CoreOS layering test#30019
travier wants to merge 1 commit intoopenshift:masterfrom
travier:rhcos-layering

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Jun 30, 2022

Reverts and reworks CoreOS layering test from:

  • b2d01f6 extracts scripts from os configs
  • a8bfe69 make test-in-cluster optional for PR builds
  • 2a15845 ci-operator/openshift/os: Move Dockerfile back here
  • 17efccb ci-operator/openshift/os: Temporarily remove layering & cluster tests

@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 30, 2022

/cc @cheesesashimi

@openshift-ci openshift-ci Bot requested a review from cheesesashimi June 30, 2022 11:22
@openshift-ci openshift-ci Bot requested review from prestist and saqibali-2k June 30, 2022 11:32
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 30, 2022

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@travier travier force-pushed the rhcos-layering branch 2 times, most recently from a405542 to 40937ca Compare July 1, 2022 09:29
cheesesashimi
cheesesashimi reviewed Jul 7, 2022
View reviewed changes
Comment thread ci-operator/config/openshift/os/openshift-os-master.yaml Outdated
cheesesashimi
cheesesashimi reviewed Jul 7, 2022
View reviewed changes
Comment thread ci-operator/config/openshift/os/openshift-os-master.yaml Outdated
@travier travier force-pushed the rhcos-layering branch 2 times, most recently from 6242f3c to ceacc1b Compare July 7, 2022 17:51
@cheesesashimi cheesesashimi mentioned this pull request Jul 7, 2022
Closed
@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 8, 2022

/retest

@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 8, 2022

This one fails on:

�[36mINFO�[0m[2022-07-08T10:59:29Z] === RUN   TestBootInClusterImage
    layering_test.go:55: targeting node ci-op-igx069l5-6a480-s6wtc-worker-b-zw4rl
=== RUN   TestBootInClusterImage/Derived_Image_Is_Built
    build_helper_test.go:99: imagestream test-boot-in-cluster-image created
    build_helper_test.go:111: base image pullspec: registry.build03.ci.openshift.org/ci-op-igx069l5/pipeline@sha256:a0e7b428aac793c5d72b44dca921386f4654b064873c65eb5616e5c817d0f248
    build_helper_test.go:112: derivation repo URL: https://github.com/coreos/fcos-derivation-example
    build_helper_test.go:113: derivation repo ref: rhcos
    build_helper_test.go:114: dockerfile path: Dockerfile
    build_helper_test.go:157: base image derivation build started
    build_helper_test.go:283: writing build log to: /logs/artifacts/derived-image-build.log
    layering_test.go:91: build did not start: build container did not start within a reasonable amount of time
=== CONT  TestBootInClusterImage
    layering_test.go:79: node ci-op-igx069l5-6a480-s6wtc-worker-b-zw4rl will not be deleted since it was not touched
--- FAIL: TestBootInClusterImage (68.53s)
    --- FAIL: TestBootInClusterImage/Derived_Image_Is_Built (68.36s)
FAIL

@cheesesashimi
Copy link
Copy Markdown
Member

cheesesashimi commented Jul 11, 2022 •
edited
Loading

Here's why this is failing:

  • The Dockerfile that was in the repo root under the rhcos branch of the coreos-layering-examples repo is no longer there. We can use one of the other directories for the Dockerfile, such as the one under inject-go-binary/Dockerfile.
  • However, that won't be enough. The RHCOS Dockerfiles originally accepted a build arg that could be used to override the base image, but this appears to have been removed. This allowed Prow to inject a newly-built version of the base image so that the derive-in-cluster test could target that instead of the prebuilt nightly one. I'll need to add an image build input to the test so that the derive-in-cluster test can override the base image in the Dockerfile.

@cheesesashimi
Copy link
Copy Markdown
Member

cheesesashimi commented Jul 11, 2022

Here's the fix for the in-cluster derivation test: openshift/os#886. I opted to take a slightly different path by embedding the Dockerfile and other test files into openshift/os repository.

@cheesesashimi
Copy link
Copy Markdown
Member

cheesesashimi commented Jul 11, 2022

I neglected to mention that once openshift/os#886 is merged, this PR should work as-is and most likely will not require additional modification.

travier
travier commented Jul 12, 2022
View reviewed changes
Comment thread ci-operator/config/openshift/os/openshift-os-master.yaml Outdated
@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 13, 2022

/retest

1 similar comment
@travier
Copy link
Copy Markdown
Member Author

travier commented Jul 18, 2022

/retest

@travier
Copy link
Copy Markdown
Member Author

travier commented Aug 4, 2022

/retest

@travier
Copy link
Copy Markdown
Member Author

travier commented Aug 5, 2022

@cheesesashimi Can you take a look at this one again?

@travier
Copy link
Copy Markdown
Member Author

travier commented Aug 5, 2022

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 4, 2022

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 4, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2022
@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 5, 2022

Ping @cheesesashimi

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 20, 2022

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2022
@cheesesashimi
Copy link
Copy Markdown
Member

cheesesashimi commented Sep 20, 2022

Hey, sorry it took me a while to review this. Everything looks reasonable to me.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 21, 2022

I'm rebasing it then :)

@travier
ci-operator/openshift/os: Re-add CoreOS layering test
cfa1049 
Reverts and reworks CoreOS layering test from:
- b2d01f6 extracts scripts from os configs
- a8bfe69 make test-in-cluster optional for PR builds
- 2a15845 ci-operator/openshift/os: Move Dockerfile back here
- 17efccb ci-operator/openshift/os: Temporarily remove layering & cluster tests
@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 21, 2022

Rebased

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 21, 2022

New changes are detected. LGTM label has been removed.

@travier
Copy link
Copy Markdown
Member Author

travier commented Sep 21, 2022

/remove-lifecycle rotten

@openshift-ci openshift-ci Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 21, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 21, 2022

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2022
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 18, 2022

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 18, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 21, 2022 •
edited
Loading

@travier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/os/master/periodic-images cfa1049 link unknown /test pj-rehearse
ci/rehearse/openshift/os/master/test-in-cluster cfa1049 link unknown /test pj-rehearse
ci/rehearse/openshift/os/master/rhcos-86-build-test-qemu cfa1049 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-os-master-periodic-validate-built-images cfa1049 link unknown /test pj-rehearse
ci/rehearse/openshift/os/master/scos-9-build-test-metal cfa1049 link unknown /test pj-rehearse
ci/rehearse/openshift/os/master/rhcos-90-build-test-metal cfa1049 link unknown /test pj-rehearse
ci/prow/openshift-image-mirror-mappings cfa1049 link true /test openshift-image-mirror-mappings
ci/rehearse/openshift/os/master/rhcos-86-build-test-metal cfa1049 link unknown /test pj-rehearse
ci/rehearse/openshift/os/master/images cfa1049 link unknown /test pj-rehearse
ci/rehearse/openshift/os/master/validate-machine-os-oci-image cfa1049 link unknown /test pj-rehearse
ci/prow/pj-rehearse cfa1049 link false /test pj-rehearse
ci/rehearse/openshift/os/master/rhcos-90-build-test-qemu cfa1049 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 7, 2022

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Dec 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 7, 2022

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prestist prestist Awaiting requested review from prestist

@saqibali-2k saqibali-2k Awaiting requested review from saqibali-2k

1 more reviewer

@cheesesashimi cheesesashimi cheesesashimi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cheesesashimi cheesesashimi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travier @cheesesashimi @openshift-bot @openshift-merge-robot