fixes in-cluster derivation test#886
Conversation
This relocates the Dockerfile, hello-world source, etc. into this repository so we do not have to rely upon https://github.com/coreos/coreos-layering-examples. The reasoning is because coreos-layering-examples does not currently have CI set up to validate that the Dockerfiles it contains can be built.
|
This LGTM but I don't have the knowledge here. |
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
added
lgtm
|
Looks sane to me, thanks!
Definitely true, but we'll also want to fix that. |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi, jmarrero, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@cheesesashimi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
This relocates the Dockerfile, hello-world source, etc. used for the in-cluster derivation test into this repository so we do not have to rely upon https://github.com/coreos/coreos-layering-examples. The reasoning is because coreos-layering-examples does not currently have CI set up to validate that the Dockerfiles it contains can be built.