Skip to content

Origin: Add optional e2e-aws-proxy job#12375

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sgreene570:origin-optional-proxy-job
Oct 6, 2020
Merged

Origin: Add optional e2e-aws-proxy job#12375
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sgreene570:origin-optional-proxy-job

Conversation

@sgreene570
Copy link
Copy Markdown
Contributor

@sgreene570 sgreene570 commented Oct 1, 2020

Add's the e2e-aws-proxy jobs as an optional, manually triggered job to openshift/origin master branch. This is for testing PR's against origin to unskip the tests skipped in #12233.

@marun
Copy link
Copy Markdown
Contributor

marun commented Oct 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@sgreene570 sgreene570 mentioned this pull request Oct 1, 2020
Closed
@sgreene570 sgreene570 force-pushed the origin-optional-proxy-job branch from b359b1d to 24e8e84 Compare October 1, 2020 18:08
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@sgreene570 sgreene570 force-pushed the origin-optional-proxy-job branch from 24e8e84 to 88d0fa2 Compare October 1, 2020 18:22
@sgreene570
Origin: Add optional e2e-aws-proxy job with no test skips
f56a361 
Add's the e2e-aws-proxy jobs as an optional,
manually triggered job to openshift/origin master branch.
This job overrides the TEST_SKIPS env var so that no tests
are skipped.
@sgreene570 sgreene570 force-pushed the origin-optional-proxy-job branch from 88d0fa2 to f56a361 Compare October 1, 2020 18:25
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 1, 2020

@sgreene570: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/origin/master/e2e-aws-proxy f56a361 link /test pj-rehearse
ci/prow/pj-rehearse f56a361 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sgreene570
Copy link
Copy Markdown
Contributor Author

sgreene570 commented Oct 1, 2020

Rehearsal failed as expected. The skip skipper works!

@marun
Copy link
Copy Markdown
Contributor

marun commented Oct 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Oct 6, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, marun, sgreene570, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 44669cf into openshift:master Oct 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 6, 2020

@sgreene570: Updated the following 3 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
Details

In response to this:

Add's the e2e-aws-proxy jobs as an optional, manually triggered job to openshift/origin master branch. This is for testing PR's against origin to unskip the tests skipped in #12233.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@marun marun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sgreene570 @marun @openshift-ci-robot @knobunc @openshift-bot @wking @openshift-merge-robot