ci-operator/step-registry/openshift/e2e/aws/proxy: Skip failing tests#12233
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 25, 2020
Merged
ci-operator/step-registry/openshift/e2e/aws/proxy: Skip failing tests#12233openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
approved
wking
force-pushed
the
proxy-test-skips
branch
2 times, most recently
from
747b4ba to
36bb0d3
Compare
A recent proxy job failed the following test-cases [1]:
[sig-arch] Managed cluster should should expose cluster services outside the cluster [Suite:openshift/conformance/parallel]
[sig-builds][Feature:Builds] build have source revision metadata started build should contain source revision information [Suite:openshift/conformance/parallel]
[sig-cli] oc adm must-gather runs successfully for audit logs [Suite:openshift/conformance/parallel]
[sig-cluster-lifecycle][Feature:Machines] Managed cluster should have machine resources [Suite:openshift/conformance/parallel]
[sig-imageregistry][Feature:ImageAppend] Image append should create images by appending them [Suite:openshift/conformance/parallel]
[sig-imageregistry][Feature:ImageInfo] Image info should display information about images [Suite:openshift/conformance/parallel]
[sig-network] Internal connectivity for TCP and UDP on ports 9000-9999 is allowed [Suite:openshift/conformance/parallel]
[sig-network] Networking should provide Internet connection for containers [Feature:Networking-IPv4] [Skipped:azure] [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-network][Feature:Router] The HAProxy router should respond with 503 to unrecognized hosts [Suite:openshift/conformance/parallel]
[sig-network][Feature:Router] The HAProxy router should serve routes that were created from an ingress [Suite:openshift/conformance/parallel]
[sig-network][Feature:Router] The HAProxy router should set Forwarded headers appropriately [Suite:openshift/conformance/parallel]
[sig-network][Feature:Router] The HAProxy router should support reencrypt to services backed by a serving certificate automatically [Suite:openshift/conformance/parallel]
This commit adds a TEST_SKIPS framework, taking advantage of:
$ openshift-tests run --help | grep 'dry-run\|--file'
If you specify the --dry-run argument, the names of each individual test that is part of the suite will be printed, one per line. You may filter this list and pass it back to the run command with the --file argument. You may also pipe a list of test names, one per line, on standard input by passing "-f -".
--dry-run Print the tests to run without executing them.
-f, --file string Create a suite from the newline-delimited test names in this file.
Grep uses basic regular expressions by default [2]. The YAML `>-` is
trimmed line folding [3], so we get one long line with no trailing
newline:
$ yaml2json <ci-operator/step-registry/openshift/e2e/aws/proxy/openshift-e2e-aws-proxy-workflow.yaml | jq -r '.workflow.env[0].default'
Image append should create images by appending them\| Image info ...should contain source revision information\| oc adm must-gather runs successfully for audit logs
The spaces from line unfolding are unfortunate, but because the
original lines have the sig-*, etc. prefixes followed by a space
before the test-case title, it's not a problem.
[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.6-e2e-aws-proxy/1308949438701506560
[2]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/grep.html
[3]: https://yaml.org/spec/1.2/spec.html#id2779048
wking
force-pushed
the
proxy-test-skips
branch
from
36bb0d3 to
7c5517d
Compare
Member
Author
|
Just vanilla flakes in the proxy rehearsal: |
Contributor
|
Changes look good. Skips are known to be working. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sgreene570, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
@wking: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent proxy job failed the following test-cases:
This commit adds a
TEST_SKIPSframework, taking advantage of:grepuses basic regular expressions by default. The YAML>-is trimmed line folding, so we get one long line with no trailing newline:The spaces from line unfolding are unfortunate, but because the original lines have the
sig-*, etc. prefixes followed by a space before the test-case title, it's not a problem.